Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prettier json output and output improvements #217

Merged
merged 3 commits into from
Apr 5, 2023

Conversation

thschue
Copy link
Contributor

@thschue thschue commented Apr 5, 2023

📑 Description

  • Decouple analysis and output (analyze -> AI analysis -> output)
  • Add structure for Json Output
  • Add problem count and overall status to JSON, use jsonIndent to make it better readable
  • Report "No issues found" in text output if nothing is found
  • Use this structure for success too
  • Move output generation to analysis to make it re-usable e.g. in API, operator
  • First tests for json output

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

Signed-off-by: Thomas Schuetz <thomas.schuetz@t-sc.eu>
@thschue thschue requested a review from a team as a code owner April 5, 2023 11:40
@thschue thschue marked this pull request as draft April 5, 2023 11:41
Signed-off-by: Thomas Schuetz <thomas.schuetz@t-sc.eu>
@thschue thschue marked this pull request as ready for review April 5, 2023 12:10
Signed-off-by: Thomas Schuetz <thomas.schuetz@t-sc.eu>
@AlexsJones AlexsJones merged commit 1f0e9f2 into main Apr 5, 2023
@AlexsJones AlexsJones deleted the chore/json-output branch April 5, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants