-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add server metrics #273
feat: add server metrics #273
Conversation
This commit add metrics path & the analyzer error metrics in the codebase. The changes have been made across all analyzers and include the addition of a new metric with label values for the analyzer's name, analyzed object's name, and namespace. The metric's value is set to the length of the analyzer objects failures. Signed-off-by: Matthis Holleville <matthish29@gmail.com>
Signed-off-by: Matthis Holleville <matthish29@gmail.com>
Signed-off-by: Matthis Holleville <matthish29@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, I think the Metric should be a Counter instead of a Gauge, but the rest look good!
Thank you for your feedback @thschue. From my understanding, the metrics can increase or decrease depending on the number of issues. The user can partially fix errors and the metrics will decrease accordingly. On the other hand, the counter can only increase which is not our case. What do you think? |
Sorry, had the wrong use-case in mind. The gauge is ok in this case! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Closes #
📑 Description
This commit add
metrics
path & the analyzer error metrics in the codebase.The changes have been made across all analyzers and include the addition of a new metric with label values for the analyzer's name, analyzed object's name, and namespace.
The metric's value is set to the length of the analyzer objects failures.
✅ Checks
ℹ Additional Information