-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add azure openai provider #309
Conversation
Hello @arbreezy , shouldn't we update the README to indicate that we have a new AI Backend available? |
Yes we will add docs, I just didn't have much time yesterday; I want to test it as well before merging. |
Tried it out, and my first observation is that the help text needs to updated to reflect these changes. I had to check the code to find out what to define as the backend. Secondly, and this might be out of scope for the actual implementation, but if I want to do an analysis with the Azure OpenAI backend after I have authenticated, I would have so explicitly state that I'm using that as a backend, even when I have no other backends in my configuration file. @AlexsJones, this is probably something we can look into in another issue, right? Third, and more importantly, I get an error when I run analyze with explain. This is the commands I ran:
|
Signed-off-by: Aris Boutselis <aris.boutselis@senseon.io>
469fe23
to
63e517e
Compare
Signed-off-by: Aris Boutselis <aris.boutselis@senseon.io>
b845043
to
4430854
Compare
hello @roberthstrand, Re: the analyze cli , I will address it, in a different PR; I agree there is no need to specify a backend if it's the only one in your configuration Thanks in advance :) ! |
ready for review? |
yes ! |
Signed-off-by: Aris Boutselis <aris.boutselis@senseon.io>
8655e83
to
c75170a
Compare
Signed-off-by: Aris Boutselis <arisboutselis08@gmail.com>
Signed-off-by: Aris Boutselis <arisboutselis08@gmail.com>
Signed-off-by: Aris Boutselis <aris.boutselis@senseon.io>
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
* feat: add additionalLabels to Service Monitor Signed-off-by: Brad McCoy <bradmccoydev@gmail.com> * feat: update additionalLabels Signed-off-by: Brad McCoy <bradmccoydev@gmail.com> --------- Signed-off-by: Brad McCoy <bradmccoydev@gmail.com>
Signed-off-by: Aris Boutselis <aris.boutselis@senseon.io>
dc07977
to
1f2e7b1
Compare
is there any documentation change required for this for end users ? wanted to validate this once with my azure openai account . |
Closes #117
π Description
This PR introduces azure openai and get viper to omit empty strings when writing to config files
β Checks
βΉ Additional Information