-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add helm chart #318
feat: add helm chart #318
Conversation
dc2787f
to
a4bf7cc
Compare
@TylerGillson can you also add a reference to this GH issue in your PR, please? |
@TylerGillson , I think it's nice to have e.g what do you think? |
@arbreezy @matthisholleville I was trying to stick with the K8s common label conventions. How about introducing Output of apiVersion: apps/v1
kind: Deployment
metadata:
name: k8sgpt
namespace: "default"
labels:
helm.sh/chart: k8sgpt-1.0.0
app.kubernetes.io/name: k8sgpt
app.kubernetes.io/instance: k8sgpt
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/version: "0.2.4"
app.k8sgpt.image: "ghcr.io/k8sgpt-ai/k8sgpt:v0.2.4" |
I was talking about in deployment's template, how you could set the container image version, which is something quite common with OSS charts. |
@arbreezy gotcha! Made the change you suggested now that I've understood you 😅 |
@AlexsJones, do we need a release-please annotation since |
I think this would make sense |
OK, I think expanding the _helpers labels function to include that label would make sense |
@arbreezy @thschue I'm happy to make whatever changes you guys feel are necessary, but I'll need a little bit more detail please. We already have |
It should work like in this manifest -> https://github.com/k8sgpt-ai/k8sgpt/blob/main/container/manifests/deployment.yaml#L22 |
2783e4d
to
00c34bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The moved Dockerfile leads to a failing CI build, please move it back to its original location.
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
* remove K8SGPT_BASEURL * add default model * add user-specified Deployment annotations * remove Values.secret.enabled --------- Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
6b07b5f
to
34f9610
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@TylerGillson: Made two suggestions, then it should work ... |
Co-authored-by: Thomas Schuetz <38893055+thschue@users.noreply.github.com> Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Co-authored-by: Thomas Schuetz <38893055+thschue@users.noreply.github.com> Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! LGTM
📑 Description
Replace static manifests with a Helm chart & update Makefile accordingly
Closes #307