feat: use OS conform path for storing cached results #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickpichler
force-pushed
the
feature/323/store-cache
branch
from
7a3fbea
to
c38fded
Compare
Instead of storing cached values in the config yaml, they are now stored under these OS specific locations: * Linux: `~/.cache/k8sgpt` * MacOS: `~/Library/Caches` * Windows: `%LocalAppData%\cache` Additionally a `Cache` package and interface has been introduced. Currently there are two implementations: * Noop - Doesn't do anything * FileBased - Stores data in files under the locations listed above fixes k8sgpt-ai#323 Signed-off-by: Patrick Pichler <git@patrickpichler.dev>
patrickpichler
force-pushed
the
feature/323/store-cache
branch
from
c38fded
to
7eddb8f
Compare
|
@matthisholleville I did some quick tests in docker images and it should work as expected, since |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #323
📑 Description
Instead of storing cached values in the config yaml, they are now stored under these OS specific locations:
~/.cache/k8sgpt~/Library/Caches%LocalAppData%\cacheAdditionally a
Cachepackage and interface has been introduced. Currently there are two implementations:✅ Checks
ℹ Additional Information