-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: get official field doc #457
Conversation
Thank you for your contribution. I think it is an important and interesting information to display to the user. What do you think @AlexsJones ? Can you test to deploy the following object and check that in case an object returns several errors, the information remains digestible please? apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
name: fake-ingress
spec:
rules:
- host: fake-ingress.example.com
http:
paths:
- backend:
service:
name: fake-service
port:
number: 80
path: /
pathType: Prefix
tls:
- hosts:
- fake-ingress.example.com
secretName: fake-secret You should have this result with actual version : 0 k8sgpt/fake-ingress(fake-ingress)
- Error: Ingress k8sgpt/fake-ingress does not specify an Ingress class.
- Error: Ingress uses the service k8sgpt/fake-service which does not exist.
- Error: Ingress uses the secret k8sgpt/fake-secret as a TLS certificate which does not exist. |
Hi,
Solution:
with the patch, I have:
|
Thank you. Shoudn't we have |
I only extract the higher level field. Il have to find Γ way to parse also the subfields from the doc |
I have an other way to find the information, I'll made some tests ... :) |
Hi,
I've added a new field in the common.Failure struct to store the kubernetes doc string. |
Thank you very much @golgoth31 ! We really appreciate the contribution and we could use it as option with |
β¦pt-ai#451) Signed-off-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: David Sabatie <david.sabatie@notrenet.com>
Signed-off-by: David Sabatie <david.sabatie@notrenet.com>
Signed-off-by: David Sabatie <david.sabatie@notrenet.com>
* feat: add configuration api route Signed-off-by: Matthis Holleville <matthish29@gmail.com> * feat: rename cache methods Signed-off-by: Matthis Holleville <matthish29@gmail.com> --------- Signed-off-by: Matthis Holleville <matthish29@gmail.com> Signed-off-by: David Sabatie <david.sabatie@notrenet.com>
β¦pt-ai#458) Signed-off-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: David Sabatie <david.sabatie@notrenet.com>
β¦pt-ai#455) * Update list.go Signed-off-by: Krishna Dutt Panchagnula <krishnadutt123@gmail.com> * fix: updated list.go to handle k8sgpt cache list crashing issue Signed-off-by: Krishna Dutt Panchagnula <krishnadutt123@gmail.com> --------- Signed-off-by: Krishna Dutt Panchagnula <krishnadutt123@gmail.com> Co-authored-by: Alex Jones <alexsimonjones@gmail.com> Signed-off-by: David Sabatie <david.sabatie@notrenet.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: David Sabatie <david.sabatie@notrenet.com>
β¦t to 51ee8ae (k8sgpt-ai#464) Signed-off-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: David Sabatie <david.sabatie@notrenet.com>
Signed-off-by: Johannes Kleinlercher <johannes@kleinlercher.at> Signed-off-by: David Sabatie <david.sabatie@notrenet.com>
β¦pt-ai#465) Signed-off-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: David Sabatie <david.sabatie@notrenet.com>
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com> Co-authored-by: Thomas Schuetz <38893055+thschue@users.noreply.github.com> Signed-off-by: David Sabatie <david.sabatie@notrenet.com>
β¦pt-ai#469) Signed-off-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: David Sabatie <david.sabatie@notrenet.com>
β¦pt-ai#458) Signed-off-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
β¦pt-ai#465) Signed-off-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: David Sabatie <david.sabatie@notrenet.com>
β¦pt-ai#469) Signed-off-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: David Sabatie <david.sabatie@notrenet.com>
Signed-off-by: David Sabatie <david.sabatie@notrenet.com>
Signed-off-by: golgoth31 <golgoth31@users.noreply.github.com>
Thank you, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left few comments. Good job ! Can you please add usage example in README please ?
Signed-off-by: David Sabatie <david.sabatie@notrenet.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Another review @AlexsJones ?
Signed-off-by: David Sabatie <david.sabatie@notrenet.com>
The readme has been updated |
This is a great first-time contribution thanks @golgoth31 |
Closes #456
π Description
Make an http call to the oficial k8S api reference page to get field documentation
β Checks
βΉ Additional Information
This is currently a first preview to be discussed.