feat: add Validating/Mutating webhook analyzer

[rakshitgondwal]

Closes #533

📑 Description

Changes made:

• Added an analyzer for Validating Webhook that checks if the pod that webhook points to is not active.
• Added an analyzer for Mutating Webhook that checks if the pod that webhook points to is not active.

✅ Checks

• My pull request adheres to the code style of this project
• My code requires changes to the documentation
• I have updated the documentation as required
• All the tests have passed

Additional Information

[arbreezy]

@rakshitgondwal would be nice to share what openai's response is as well based on the error messages you feed it

[rakshitgondwal]

@rakshitgondwal would be nice to share what openai's response is as well based on the error messages you feed it

[arbreezy]

@rakshitgondwal would be nice to share what openai's response is as well based on the error messages you feed it

I also left a few comments, thanks for your contribution !

[rakshitgondwal]

I also left a few comments, thanks for your contribution !

Sorry, but I can't see your comments, can you please re check?

[rakshitgondwal]

Thank you for the merge!

[AlexsJones]

Hi @rakshitgondwal this was my fault for merging entirely.

Looking at the code can you explain what it's doing?
Because to my eyes it looks like you are looping through each webhook, then looping through every pod in the cluster and checking running status. This means it's looping multiple times

Keep me honest here @arbreezy

[rakshitgondwal]

Oh yes @AlexsJones, even I am at fault here for misunderstanding the issue. I didn't think about this thoroughly once the PR was approved. Should have made a Draft PR first and then should've asked for feedback on the logic.

But, after giving this a second thought, I had one question that should the analyzer be pointing to a service or a pod? Because in the WebhookConfiguration we mention the service that the webhook points to so how come would we be able to point to a pod? Correct me if I'm wrong here, and yes I'd like to fix this if you allow me.

[AlexsJones]

As per here, use the service-name the webhook is bound too and check if the service has pods that are active ( at least 1 )
that should be the real logic

[rakshitgondwal]

I was trying out this logic, but it is not working. I added a LabelSelector while getting the pods to be service.name, then looped on the pods and check if they are running. Can you help me out with this? @AlexsJones

svc := webhook.ClientConfig.Service
pods, err := a.Client.GetClient().CoreV1().Pods(a.Namespace).List(context.Background(), v1.ListOptions{LabelSelector: svc.Name})
	if err != nil {
		return nil, err
	}
	activePods := 0
	for _, pod := range pods.Items {
		if pod.Status.Phase == "Running" {
			activePods++
		}
	}
	if activePods == 0 {
		doc := apiDoc.GetApiDocV2("spec.webhook")
		failures = append(failures, common.Failure{

[AlexsJones]

I can take a look at implementing it a version of this and seeing whats wrong later today

[AlexsJones]

#553