Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: admission webhooks #553

Merged
merged 11 commits into from
Jul 14, 2023
Merged

feat: admission webhooks #553

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
385a8ea
feat: add Validating/Mutating webhook analyzer
rakshitgondwal Jul 7, 2023
10f96d3
change conditions
rakshitgondwal Jul 7, 2023
32bb7d9
fix: use GetClient to get pods and mask pod name
rakshitgondwal Jul 12, 2023
2a253cb
fix: add new cases in util.GetParent
rakshitgondwal Jul 12, 2023
ec925aa
Merge branch 'main' into feat/533/webhookAnalyzer
Jul 12, 2023
ca25114
feat: implements webhooks
AlexsJones Jul 13, 2023
e02d922
Merge branch 'main' into feat/admission-webhooks
AlexsJones Jul 13, 2023
2f020b6
feat: implements webhooks
AlexsJones Jul 13, 2023
e4f117e
Merge branch 'feat/admission-webhooks' of github.com:k8sgpt-ai/k8sgpt…
AlexsJones Jul 13, 2023
3b870e7
feat: implements webhooks
AlexsJones Jul 13, 2023
ffccafe
feat: implements webhooks
AlexsJones Jul 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 11 additions & 0 deletions pkg/analyzer/mutating_webhook.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,17 @@ func (MutatingWebhookAnalyzer) Analyze(a common.Analyzer) ([]common.Result, erro
// Get the service
service, err := a.Client.GetClient().CoreV1().Services(svc.Namespace).Get(context.Background(), svc.Name, v1.GetOptions{})
if err != nil {
AlexsJones marked this conversation as resolved.
Show resolved Hide resolved
AlexsJones marked this conversation as resolved.
Show resolved Hide resolved
// If the service is not found, we can't check the pods
failures = append(failures, common.Failure{
Text: fmt.Sprintf("Service %s not found as mapped to by Mutating Webhook %s", svc.Name, webhook.Name),
KubernetesDoc: apiDoc.GetApiDocV2("spec.webhook.clientConfig.service"),
Sensitive: []common.Sensitive{
AlexsJones marked this conversation as resolved.
Show resolved Hide resolved
{
Unmasked: webhookConfig.Namespace,
Masked: util.MaskString(webhookConfig.Namespace),
},
},
})
return nil, err
}

Expand Down