Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fixing edge cases with missing wh service #561

Merged
merged 4 commits into from
Jul 19, 2023
Merged

chore: fixing edge cases with missing wh service #561

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e0f1714
chore: fixing edge cases with missing wh service
AlexsJones Jul 18, 2023
0653efe
chore: fixing edge cases with missing wh service
AlexsJones Jul 18, 2023
7dbd0bb
Update validating_webhook.go
AlexsJones Jul 19, 2023
2073254
Merge branch 'main' into chore/wh-fix
Jul 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion pkg/analyzer/validating_webhook.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,9 @@ func (ValidatingWebhookAnalyzer) Analyze(a common.Analyzer) ([]common.Result, er
for _, webhookConfig := range validatingWebhooks.Items {
for _, webhook := range webhookConfig.Webhooks {
var failures []common.Failure

if webhook.ClientConfig.Service == nil {
arbreezy marked this conversation as resolved.
Show resolved Hide resolved
continue
}
svc := webhook.ClientConfig.Service
// Get the service
service, err := a.Client.GetClient().CoreV1().Services(svc.Namespace).Get(context.Background(), svc.Name, v1.GetOptions{})
Expand Down