Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: also fixes bug if the events feed is empty #73

Merged
merged 1 commit into from
Mar 25, 2023
Merged

Conversation

AlexsJones
Copy link
Member

Closes #

πŸ“‘ Description

βœ… Checks

  • [ x] My pull request adheres to the code style of this project
  • [x ] My code requires changes to the documentation
  • [ x] I have updated the documentation as required
  • [ x] All the tests have passed

β„Ή Additional Information

Signed-off-by: AlexsJones <alexsimonjones@gmail.com>
Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thschue thschue merged commit a1093dc into main Mar 25, 2023
@thschue thschue deleted the feat/cmd-refactor branch March 25, 2023 21:59
This was referenced Mar 25, 2023
fyuan1316 pushed a commit to fyuan1316/k8sgpt that referenced this pull request Jun 26, 2023
* feat: fix grpc client creation slightly

Signed-off-by: Alex Jones <alexsimonjones@gmail.com>

* feat: fix grpc client creation slightly

Signed-off-by: Alex Jones <alexsimonjones@gmail.com>

---------

Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants