Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set result name and namespace to trivy vulnreport and configaudi… #869

Merged
merged 6 commits into from
Feb 18, 2024

Conversation

jkleinlercher
Copy link
Contributor

Closes k8sgpt-ai/k8sgpt-operator#240 and replaces #678

📑 Description

this is the better approach to fix k8sgpt-ai/k8sgpt-operator#240 by using the resource name and namespace of the trivy ConfigAuditReport and VulnerabilityReport

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

@jkleinlercher jkleinlercher requested review from a team as code owners January 15, 2024 17:00
…treport

Signed-off-by: Johannes Kleinlercher <johannes.kleinlercher@suxess-it.com>
@jkleinlercher
Copy link
Contributor Author

Thanks for your approval @AlexsJones . Could you please merge it, too? Thank you!

@AlexsJones
Copy link
Member

Mind taking a look at the linter issue locally @jkleinlercher ?

@jkleinlercher
Copy link
Contributor Author

Mind taking a look at the linter issue locally @jkleinlercher ?

I needed to increase the timeout in 5840b8e . Don't know why this is needed, but I saw you also already increased the timeout.

@jkleinlercher
Copy link
Contributor Author

@AlexsJones would merge this? Would be great to have this in the next release :)

@AlexsJones AlexsJones merged commit a3cd7e6 into k8sgpt-ai:main Feb 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG]: Kind/Name of result not existing for k8sgpt-operator
2 participants