-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Google Vertex AI as provider to utilize gemini via GCP #984
Conversation
2afe94c
to
ecb95f4
Compare
/retest |
ecb95f4
to
105fc0f
Compare
Signed-off-by: Mario Fahlandt <mfahlandt@pixel-haufen.de>
105fc0f
to
75eb011
Compare
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
It lgtm but can't test it as I dont have vertex ai, it will be nice if you can share a screenshot of vertex integration while running k8sgpt analyze -e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks good.
i just comment minor comments.
and does what if gemini API support other regions? then maybe we don't need to maintain this provider.
does it takes long time to gemini API supports other regions??
We could potentially then remove this provider. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall good!
and need to resolve DCO
Signed-off-by: Mario Fahlandt <mfahlandt@pixel-haufen.de>
6043321
to
10bda51
Compare
yeah the signing was missing, for whatever reason :( |
📑 Description
Adds VertexAI of GCP as a possible provider - this was asked as a possible feature here: https://k8sgpt.slack.com/archives/C050SKW7SHF/p1708033891149459
Another reason for adding it - currently Gemini API is not supported in a lot of regions (e.g. any EU Country + Australia) but Vertex AI is available to be used via GCP (https://ai.google.dev/available_regions)
✅ Checks
ℹ Additional Information