Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: grpc-gateway file generation #20

Closed
wants to merge 2 commits into from
Closed

fix: grpc-gateway file generation #20

wants to merge 2 commits into from

Conversation

sbadla1
Copy link

@sbadla1 sbadla1 commented Jan 4, 2024 •
edited

Closes #

📑 Description

This PR fixes the the grpc-gateway code generation.

Updates:

  • Fixed grpc-gateway plugin path in protobuf/buf.gen.go-server.yaml
  • Added http mapping for "Analyze" and "ListIntegrations" methods

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

@sahilbadla
fix: grpc-gateway file generation
4b8054c 
Signed-off-by: Sahil Badla <sahil_badla@intuit.com>
@sbadla1 sbadla1 changed the title fix : grpc-gateway file generation fix: grpc-gateway file generation Jan 4, 2024
@sbadla1 sbadla1 mentioned this pull request Jan 4, 2024
Merged
4 tasks
@sahilbadla
fix: annotation for analyze method
a77a312 
Signed-off-by: Sahil Badla <sahil_badla@intuit.com>
AlexsJones
AlexsJones requested changes Feb 8, 2024
View reviewed changes
Copy link
Member

@AlexsJones AlexsJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need some clarification on the error when reproducing

@AlexsJones
Copy link
Member

Merged here #22

@AlexsJones AlexsJones closed this Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexsJones AlexsJones AlexsJones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sbadla1 @AlexsJones @sahilbadla