Remove local gopath #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit updates several packages to their latest version such as cni plugins, rdma cni, ginkgo, gomega. in addition update local imports to point to k8snetworkplumbingwg instead of Mellanox org Signed-off-by: adrianc <adrianc@nvidia.com>
use gomodules instead. Signed-off-by: adrianc <adrianc@nvidia.com>
- extend supported version reported by CNI - set interface index in IPConfig returned from ipam plugin Signed-off-by: adrianc <adrianc@nvidia.com>
- refactor makefile, clean up unused targets remove the use of .gopath, restructure and add target description - update .gitignore file - add test-image target to buildtest workflow Signed-off-by: adrianc <adrianc@nvidia.com>
zeeke
approved these changes
May 29, 2024
| uses: docker/setup-buildx-action@v2 | ||
|
|
||
| - name: build and test ib-sriov-cni image | ||
| run: make test-image |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.