-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suppress error message in cmdDel, in thick plugin #1084
Conversation
Changes Unknown when pulling 5d64ec3 on s1061123:fix/del-noerr into ** on k8snetworkplumbingwg:master**. |
This fix suppress error message in thick plugin's shim, for DEL command, to align with CNI spec. Fix k8snetworkplumbingwg#1080
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the change to preserve the logging (when available)
In order to have a fix for k8snetworkplumbingwg/multus-cni#1084 which hit us on lifecycle tests / cluster-sync. See kubevirt#1543 Signed-off-by: Or Shoval <oshoval@redhat.com>
It will aslo ignore common errors raised by CNI. I don't think this is what we expected. Here are some containerd logs:
|
Raise an issue for discusstion. #1239 |
This fix suppress error message in thick plugin's shim, for DEL command, to align with CNI spec.
Fix #1080