Add scc template #37
Merged
Add scc template #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maiqueb
force-pushed
the
add-scc-template
branch
2 times, most recently
from
a47a808
to
9a51ffe
Compare
A condition was added to the `generate_manifests` script: it does not make sense to generate container runtime parametrized manifests for **anything** other than the daemonset spec of the controller - since these are container runtime agnostic. Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
maiqueb
force-pushed
the
add-scc-template
branch
from
9a51ffe
to
18b29f8
Compare
|
With this SCC we can deploy the controller in openshift, but it fails because it cannot find the multus-socket: We need to get multus-v4 on openshift to the controllers to successfully come up. |
|
Let's fly with this for the time being. Once we have CNO optionally install multus-v4, we can revisit, and give proper feedback; no sense to hold off MVP a downstream dependency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR provides an SCC manifest, without which deployment of the project in an Openshift cluster would fail, since mounting host file system paths requires the following permissions to be granted (for Openshift clusters):
hostPathvolume entry)Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #33
Special notes for your reviewer (optional):