-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apparent typo in annotation name #17
Comments
CC @s1061123 |
@plwhite thanks for reporting this. This repo follows the implementation from intel/multus-cni. I think it would be less disruptive to fix the document. Could you also raise it there? |
Thank you for the issue, @plwhite ! |
Fair enough - my instinct is just to change the spec now for consistency with the code. |
Folks, I investigated the current implementations (as far as I know, only in Open Sourced) of NPWG Spec.
So I suppose chaning NPWG lib (and multus) is the easy way than changing others.
How about that? Comments and questions are welcome. |
Works for me, thanks. |
This change fixes k8snetworkplumbingwg#17, mismatching status annotation name between implementation and specification. During transitional period (i.e. until next version up), old status annotation is kept for backward compatibility.
This change fixes k8snetworkplumbingwg#17, mismatching status annotation name between implementation and specification. During transitional period (i.e. until next version up), old status annotation is kept for backward compatibility.
What happend:
Created some resources using multus and multiple networks. Annotations added to pods did not match spec.
What you expected to happen:
According to the spec (https://docs.google.com/document/d/1Ny03h6IDVy_e_vmElOqR7UdTPAG_RNydhVE1Kx54kFQ/) this should lead to an annotation
k8s.v1.cni.cncf.io/network-status
, but it appeared that the annotation I got wask8s.v1.cni.cncf.io/networks-status
(note the extra s to make itnetworks
, notnetwork
).That appears to be a simple typo in the code.
The text was updated successfully, but these errors were encountered: