[release-0.19] DaemonSet, Add Priority class #172
Conversation
As part of https://bugzilla.redhat.com/show_bug.cgi?id=1953482 We are adding Priority Class [1] to each network component. The motivation is to make the control plane pods less sensitive to preemption than user workloads. Pods that are node specific will have the higher build-in priority, since preempting them from a specific node, makes them unavailable until they are rescheduled on that specific node. Pods that are network control plane, but are not node specific will have system-cluster-critical, which would still make them more important than user and custom workloads, but less than system-node-critical. Since ovs-cni pod should run on each node, assign system-node-critical pc to it. [1] https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/ Signed-off-by: Or Shoval <oshoval@redhat.com>
kubevirt-bot
added
dco-signoff: yes
|
Hi @oshoval. Thanks for your PR. I'm waiting for a k8snetworkplumbingwg member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
@EdDev: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
oshoval
changed the title
|
/ok-to-test |
|
@AlonaKaplan: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Thanks for trying /hold |
kubevirt-bot
added
the
do-not-merge/hold
|
/ok-to-test |
kubevirt-bot
added
ok-to-test
|
sanity of the release vanilla /hold cancel |
kubevirt-bot
removed
the
do-not-merge/hold
|
/release-note-none |
kubevirt-bot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oshoval, phoracek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
Thanks @phoracek |
|
Thanks |
Manual cherry-pick of #164
As part of https://bugzilla.redhat.com/show_bug.cgi?id=1953482
We are adding Priority Class [1] to each network component.
The motivation is to make the control plane pods less sensitive to preemption
than user workloads.
Pods that are node specific will have the higher build-in priority,
since preempting them from a specific node, makes them unavailable
until they are rescheduled on that specific node.
Pods that are network control plane, but are not node specific
will have system-cluster-critical, which would still make them more important
than user and custom workloads, but less than system-node-critical.
Since ovs-cni pod should run on each node,
assign system-node-critical pc to it.
[1] https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/
Signed-off-by: Or Shoval oshoval@redhat.com