Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bump-kubevirtci.sh #321

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Fix bump-kubevirtci.sh #321

merged 1 commit into from
Jul 29, 2024

Conversation

oshoval
Copy link
Member

@oshoval oshoval commented Jul 3, 2024 •
edited
Loading

What this PR does / why we need it:
Since line format was changed to allow overriding default value, need to adapt the bump script.

Special notes for your reviewer:

Release note:

None

@oshoval
Fix bump-kubevirtci.sh
3dc9d60 
Since line format was changed to allow overriding default value,
need to adapt the bump script.

Signed-off-by: Or Shoval <oshoval@redhat.com>
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 3, 2024
@oshoval
Copy link
Member Author

oshoval commented Jul 3, 2024 •
edited
Loading

/cc @phoracek
ptal
(no need release for that of course, thanks)

phoracek
phoracek approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@phoracek phoracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2024
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oshoval, phoracek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2024
@kubevirt-bot kubevirt-bot merged commit 90d65bf into k8snetworkplumbingwg:main Jul 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phoracek phoracek phoracek approved these changes

Assignees

@phoracek phoracek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oshoval @kubevirt-bot @phoracek