Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cni version to 1.0.0 #60

Merged
merged 2 commits into from
May 29, 2024

Conversation

adrianchiris
Copy link
Collaborator

No description provided.

- bump cni plugins
- bump ginkgo and gomega

Signed-off-by: adrianc <adrianc@nvidia.com>
update plugin to support cni version 1.0.0

Signed-off-by: adrianc <adrianc@nvidia.com>
@adrianchiris adrianchiris requested a review from SchSeba May 28, 2024 10:18
@adrianchiris
Copy link
Collaborator Author

adrianchiris commented May 28, 2024

@SchSeba PTAL, id like to cut a new release once this is merged

we dont have the caching issue here (like we had in sriov-cni) as we dont cache netconf.

Copy link
Member

@zeeke zeeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adrianchiris
Copy link
Collaborator Author

@SchSeba PTAL

thx for reviewing @zeeke !

Copy link
Collaborator

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

not related to this PR but we must add unit-test lane in CI.
I test it locally and all good :)

@SchSeba SchSeba merged commit a563b2f into k8snetworkplumbingwg:master May 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants