Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update error messages to show why no interface is selected #434

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Update error messages to show why no interface is selected #434

merged 1 commit into from
Oct 16, 2023

Conversation

vrindle
Copy link
Contributor

@vrindle vrindle commented Apr 28, 2023

When the SRIOV network node state is not properly initialized it can hit the error "no supported NIC is selected by the nicSelector" even though the NIC may be indeed be selected. This commit updates the error message to ensure that if the user is configuring a NIC that is supported, then the error is because the SRIOV network node state is not properly initialized.

@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@vrindle vrindle mentioned this pull request Apr 28, 2023
Merged
@vrindle
Copy link
Contributor Author

vrindle commented Apr 28, 2023

@wizhaoredhat
@bn222

@vrindle
Copy link
Contributor Author

vrindle commented Apr 28, 2023

Please ensure that this PR: #422 gets merged before merging the current PR.

@wizhaoredhat
Copy link
Contributor

wizhaoredhat commented Apr 28, 2023 •
edited
Loading

I think these changes would benefit from a GitHub issue being created for sriov-network-operator. One showing the deficiency with the current logging (with example config and log) with maybe several test cases with the example config. Then showing with these set of PRs applied, what the logs would look like instead. Highlighting the improvements and debug-ability.

@bn222
Copy link
Collaborator

bn222 commented May 10, 2023

This PR needs to be rebased on the other PR. Git will automatically detect that the other PR already contains the cleanup and if that other PR is merged, this PR will only contain the final commit

SchSeba
SchSeba requested changes May 16, 2023
View reviewed changes
Copy link
Collaborator

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments.

in general I think this will spam the logs with info about all the devices on the system everytime someone apply a policy no?

Also I don't understand the change is only on the logs the end user when applying a yaml with oc apply will not see any change in the message?

pkg/webhook/validate.go Show resolved Hide resolved
pkg/webhook/validate.go Outdated Show resolved Hide resolved
pkg/webhook/validate.go Show resolved Hide resolved
pkg/webhook/validate_test.go Outdated Show resolved Hide resolved
pkg/webhook/validate_test.go Outdated Show resolved Hide resolved
@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@vrindle
Copy link
Contributor Author

vrindle commented Jun 19, 2023

some comments.

in general I think this will spam the logs with info about all the devices on the system everytime someone apply a policy no?

It's only when there's no compatible devices, it will provide a summary of all the interfaces on every node and why that failed to match.

Also I don't understand the change is only on the logs the end user when applying a yaml with oc apply will not see any change in the message?

It does output to the logs to improve debugability. It will output if there's no matching error.

@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@vrindle vrindle force-pushed the fix_error_message_revised branch from 599a8b4 to 9fda8e0 Compare July 4, 2023 11:26
@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@vrindle
Copy link
Contributor Author

vrindle commented Jul 4, 2023 •
edited
Loading

@wizhaoredhat I tested out the changes on my system.It lists out the interfaces and describes exactly what is not matching on each node. This is what partial matching logs look:

] [] [] [{kubectl-client-side-apply Update sriovnetwork.openshift.io/v1 2023-07-04 10:44:29 +0000 UTC FieldsV1 {"f:metadata":{"f:annotations":{".":{},"f:kubectl.kubernetes.io/last-applied-configuration":{}}},"f:spec":{".":{},"f:deviceType":{},"f:eSwitchMode":{},"f:nicSelector":{".":{},"f:pfNames":{},"f:rootDevices":{}},"f:nodeSelector":{".":{},"f:feature.node.kubernetes.io/network-sriov.capable":{}},"f:numVfs":{},"f:priority":{},"f:resourceName":{}}} }]} {mlxnics map[feature.node.kubernetes.io/network-sriov.capable:true] 6 0 12 {  [0000:3b:00.0] [ensqnp0#1-11] } netdevice false false  switchdev } {}}
I0704 10:44:29.558338       1 validate.go:240] validatePolicyForNodeState(): validate policy policy-ml for node worker-advnetlab40.
I0704 10:44:29.558377       1 validate.go:223] worker-advnetlab40: Interface: eno1 was not selected, since NIC model could not be validated due to the following error: interface PCI address: 0000:18:00.0 not found in root devices
I0704 10:44:29.558388       1 validate.go:223] worker-advnetlab40: Interface: eno2 was not selected, since NIC model could not be validated due to the following error: interface PCI address: 0000:18:00.1 not found in root devices
I0704 10:44:29.558392       1 validate.go:223] worker-advnetlab40: Interface: ens1f0 was not selected, since NIC model could not be validated due to the following error: interface name: 0000:3b:00.0 not found in physical function names
I0704 10:44:29.558396       1 validate.go:223] worker-advnetlab40: Interface: ens1f1 was not selected, since NIC model could not be validated due to the following error: interface PCI address: 0000:3b:00.1 not found in root devices
I0704 10:44:29.558404       1 validate.go:223] worker-advnetlab40: Interface: ens2f0np0 was not selected, since NIC model could not be validated due to the following error: interface PCI address: 0000:5e:00.0 not found in root devices
I0704 10:44:29.558408       1 validate.go:223] worker-advnetlab40: Interface: ens2f1np1 was not selected, since NIC model could not be validated due to the following error: interface PCI address: 0000:5e:00.1 not found in root devices
I0704 10:44:29.558412       1 validate.go:223] worker-advnetlab40: Interface: ens4f0np0 was not selected, since NIC model could not be validated due to the following error: interface PCI address: 0000:af:00.0 not found in root devices
I0704 10:44:29.558416       1 validate.go:223] worker-advnetlab40: Interface: ens4f1np1 was not selected, since NIC model could not be validated due to the following error: interface PCI address: 0000:af:00.1 not found in root devices
I0704 10:44:29.558421       1 validate.go:277] validateConflictPolicy(): validate policy policy-ml against policy default
I0704 10:44:29.558426       1 validate.go:277] validateConflictPolicy(): validate policy policy-ml against policy policy-mlx
I0704 10:44:29.558431       1 validate.go:277] validateConflictPolicy(): validate policy policy-ml against policy sriov-mgmt-node-policy
I0704 10:44:29.558436       1 validate.go:277] validateConflictPolicy(): validate policy policy-ml against policy sriov-workload-node-policy
I0704 10:44:29.558442       1 validate.go:240] validatePolicyForNodeState(): validate policy policy-ml for node worker-advnetlab41.
I0704 10:44:29.558455       1 validate.go:223] worker-advnetlab41: Interface: eno1 was not selected, since NIC model could not be validated due to the following error: interface PCI address: 0000:18:00.0 not found in root devices
I0704 10:44:29.558460       1 validate.go:223] worker-advnetlab41: Interface: eno2 was not selected, since NIC model could not be validated due to the following error: interface PCI address: 0000:18:00.1 not found in root devices
I0704 10:44:29.558464       1 validate.go:223] worker-advnetlab41: Interface: ens1f0 was not selected, since NIC model could not be validated due to the following error: interface name: 0000:3b:00.0 not found in physical function names
I0704 10:44:29.558468       1 validate.go:223] worker-advnetlab41: Interface: ens1f1 was not selected, since NIC model could not be validated due to the following error: interface PCI address: 0000:3b:00.1 not found in root devices
I0704 10:44:29.558473       1 validate.go:223] worker-advnetlab41: Interface: ens4f0np0 was not selected, since NIC model could not be validated due to the following error: interface PCI address: 0000:af:00.0 not found in root devices
I0704 10:44:29.558477       1 validate.go:223] worker-advnetlab41: Interface: ens4f1np1 was not selected, since NIC model could not be validated due to the following error: interface PCI address: 0000:af:00.1 not found in root devices
I0704 10:44:29.558481       1 validate.go:223] worker-advnetlab41: Interface: ens8f0np0 was not selected, since NIC model could not be validated due to the following error: interface PCI address: 0000:d8:00.0 not found in root devices
I0704 10:44:29.558485       1 validate.go:223] worker-advnetlab41: Interface: ens8f1np1 was not selected, since NIC model could not be validated due to the following error: interface PCI address: 0000:d8:00.1 not found in root devices
I0704 10:44:29.558489       1 validate.go:277] validateConflictPolicy(): validate policy policy-ml against policy default
I0704 10:44:29.558494       1 validate.go:277] validateConflictPolicy(): validate policy policy-ml against policy policy-mlx
I0704 10:44:29.558498       1 validate.go:277] validateConflictPolicy(): validate policy policy-ml against policy sriov-mgmt-node-policy
I0704 10:44:29.558503       1 validate.go:277] validateConflictPolicy(): validate policy policy-ml against policy sriov-workload-node-policy
I0704 10:44:29.558531       1 start.go:107] sending response: {"kind":"AdmissionReview","apiVersion":"admission.k8s.io/v1","response":{"uid":"e6a410cf-be77-472b-8627-df9cb88dbd4a","allowed":true}}

@vrindle
Copy link
Contributor Author

vrindle commented Jul 4, 2023

No matching logs look like this:

I0704 11:13:56.256099       1 validate.go:240] validatePolicyForNodeState(): validate policy policy-ml for node worker-advnetlab40.
I0704 11:13:56.256145       1 validate.go:223] worker-advnetlab40: Interface: eno1 was not selected, since NIC model could not be validated due to the following error: interface PCI address: 0000:18:00.0 not found in root devices
I0704 11:13:56.256151       1 validate.go:223] worker-advnetlab40: Interface: eno2 was not selected, since NIC model could not be validated due to the following error: interface PCI address: 0000:18:00.1 not found in root devices
I0704 11:13:56.256155       1 validate.go:223] worker-advnetlab40: Interface: ens1f0 was not selected, since NIC model could not be validated due to the following error: interface PCI address: 0000:3b:00.0 not found in root devices
I0704 11:13:56.256159       1 validate.go:223] worker-advnetlab40: Interface: ens1f1 was not selected, since NIC model could not be validated due to the following error: interface PCI address: 0000:3b:00.1 not found in root devices
I0704 11:13:56.256163       1 validate.go:223] worker-advnetlab40: Interface: ens2f0np0 was not selected, since NIC model could not be validated due to the following error: interface PCI address: 0000:5e:00.0 not found in root devices
I0704 11:13:56.256167       1 validate.go:223] worker-advnetlab40: Interface: ens2f1np1 was not selected, since NIC model could not be validated due to the following error: interface PCI address: 0000:5e:00.1 not found in root devices
I0704 11:13:56.256172       1 validate.go:223] worker-advnetlab40: Interface: ens4f0np0 was not selected, since NIC model could not be validated due to the following error: interface PCI address: 0000:af:00.0 not found in root devices
I0704 11:13:56.256176       1 validate.go:223] worker-advnetlab40: Interface: ens4f1np1 was not selected, since NIC model could not be validated due to the following error: interface PCI address: 0000:af:00.1 not found in root devices
I0704 11:13:56.256181       1 validate.go:277] validateConflictPolicy(): validate policy policy-ml against policy default
I0704 11:13:56.256188       1 validate.go:277] validateConflictPolicy(): validate policy policy-ml against policy policy-mlx
I0704 11:13:56.256192       1 validate.go:277] validateConflictPolicy(): validate policy policy-ml against policy sriov-mgmt-node-policy
I0704 11:13:56.256210       1 validate.go:277] validateConflictPolicy(): validate policy policy-ml against policy sriov-workload-node-policy
I0704 11:13:56.256215       1 validate.go:240] validatePolicyForNodeState(): validate policy policy-ml for node worker-advnetlab41.
I0704 11:13:56.256228       1 validate.go:223] worker-advnetlab41: Interface: eno1 was not selected, since NIC model could not be validated due to the following error: interface PCI address: 0000:18:00.0 not found in root devices
I0704 11:13:56.256232       1 validate.go:223] worker-advnetlab41: Interface: eno2 was not selected, since NIC model could not be validated due to the following error: interface PCI address: 0000:18:00.1 not found in root devices
I0704 11:13:56.256236       1 validate.go:223] worker-advnetlab41: Interface: ens1f0 was not selected, since NIC model could not be validated due to the following error: interface PCI address: 0000:3b:00.0 not found in root devices
I0704 11:13:56.256240       1 validate.go:223] worker-advnetlab41: Interface: ens1f1 was not selected, since NIC model could not be validated due to the following error: interface PCI address: 0000:3b:00.1 not found in root devices
I0704 11:13:56.256245       1 validate.go:223] worker-advnetlab41: Interface: ens4f0np0 was not selected, since NIC model could not be validated due to the following error: interface PCI address: 0000:af:00.0 not found in root devices
I0704 11:13:56.256248       1 validate.go:223] worker-advnetlab41: Interface: ens4f1np1 was not selected, since NIC model could not be validated due to the following error: interface PCI address: 0000:af:00.1 not found in root devices
I0704 11:13:56.256252       1 validate.go:223] worker-advnetlab41: Interface: ens8f0np0 was not selected, since NIC model could not be validated due to the following error: interface PCI address: 0000:d8:00.0 not found in root devices
I0704 11:13:56.256256       1 validate.go:223] worker-advnetlab41: Interface: ens8f1np1 was not selected, since NIC model could not be validated due to the following error: interface PCI address: 0000:d8:00.1 not found in root devices
I0704 11:13:56.256261       1 validate.go:277] validateConflictPolicy(): validate policy policy-ml against policy default
I0704 11:13:56.256265       1 validate.go:277] validateConflictPolicy(): validate policy policy-ml against policy policy-mlx
I0704 11:13:56.256285       1 validate.go:277] validateConflictPolicy(): validate policy policy-ml against policy sriov-mgmt-node-policy
I0704 11:13:56.256291       1 validate.go:277] validateConflictPolicy(): validate policy policy-ml against policy sriov-workload-node-policy
I0704 11:13:56.256313       1 start.go:107] sending response: {"kind":"AdmissionReview","apiVersion":"admission.k8s.io/v1","response":{"uid":"fe38cb53-f4db-46a3-8e09-c17dadea0f31","allowed":true}}```

@vrindle vrindle force-pushed the fix_error_message_revised branch from 9fda8e0 to d9c440d Compare July 4, 2023 11:35
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

adrianchiris
adrianchiris reviewed Aug 16, 2023
View reviewed changes
Copy link
Collaborator

@adrianchiris adrianchiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comments, otherwise lgtm

pkg/webhook/validate.go Outdated Show resolved Hide resolved
pkg/webhook/validate.go Outdated Show resolved Hide resolved
@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@vrindle
Update error messages to show why no interface is selected
efb48ad 
When the SRIOV network node state is not properly initialized it can hit the error "no supported NIC is selected by the nicSelector" even though the NIC may be indeed be selected. This commit updates the error message to ensure that if the user is configuring a NIC that is supported, then the error is because the SRIOV network node state is not properly initialized.
@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

adrianchiris
adrianchiris approved these changes Oct 15, 2023
View reviewed changes
Copy link
Collaborator

@adrianchiris adrianchiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adrianchiris
Copy link
Collaborator

@SchSeba @zeeke PTAL, lets get this one in (its been open for a while)

@bn222 bn222 merged commit a3ea7b1 into k8snetworkplumbingwg:master Oct 16, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianchiris adrianchiris adrianchiris approved these changes

@SchSeba SchSeba Awaiting requested review from SchSeba

@maiqueb maiqueb Awaiting requested review from maiqueb

@wizhaoredhat wizhaoredhat Awaiting requested review from wizhaoredhat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vrindle @wizhaoredhat @bn222 @adrianchiris @SchSeba @maiqueb