Skip vf configuration when not found in VF group #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcelo Guerrero <marguerr@redhat.com>
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Pull Request Test Coverage Report for Build 6904899519
💛 - Coveralls |
bn222
reviewed
Nov 7, 2023
| // Do not configure VF which is not part of any VF Group. | ||
| if !found { | ||
| continue | ||
| } |
There was a problem hiding this comment.
This is essentially filtering the list of addresses to process. Now, the body of the loop does much too much imo. Let's take the opportunity to refactor this whole function to have a more proper way to filter the list
There was a problem hiding this comment.
done, please have a look again
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
mlguerrero12
force-pushed
the
fixconfigvfgroup
branch
from
db58834
to
16efbac
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
mlguerrero12
force-pushed
the
fixconfigvfgroup
branch
from
16efbac
to
ce298b2
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Signed-off-by: Marcelo Guerrero <marguerr@redhat.com>
mlguerrero12
force-pushed
the
fixconfigvfgroup
branch
from
ce298b2
to
7390d13
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
|
created a test in #541 to show the issue. I added here as well. It should pass now. |
|
OCP job passed (with new added test). There is a problem setting up the k8s job (not related to this pr). |
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
adrianchiris
approved these changes
Nov 21, 2023
| if sriovnetworkv1.StringInArray(group.DeviceType, DpdkDrivers) { | ||
| dpdkDriver = group.DeviceType | ||
| } | ||
| if err != nil { |
There was a problem hiding this comment.
thx for moving this check !
zeeke
reviewed
Nov 23, 2023
| @@ -1071,6 +1071,83 @@ var _ = Describe("[sriov] operator", func() { | |||
| })) | |||
| }) | |||
|
|
|||
| It("Should configure the mtu only for vfs which are part of the partition", func() { | |||
There was a problem hiding this comment.
Thanks for moving the test into this PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.