Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[software-bridges 2/x] report VF representor name in SriovNetworkNodeState.Status field #690

Merged
merged 2 commits into from
Jun 25, 2024
Merged

[software-bridges 2/x] report VF representor name in SriovNetworkNodeState.Status field #690

merged 2 commits into from
Jun 25, 2024

Conversation

ykulazhenkov
Copy link
Collaborator

@ykulazhenkov ykulazhenkov commented Apr 29, 2024 •
edited
Loading

Add support for reporting VF representor name when the NIC is in switchev mode

Report VF representor field as described in the desing doc

@github-actions GitHub Actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

coveralls commented Apr 29, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9203658166

Details

  • 83 of 93 (89.25%) changed or added relevant lines in 6 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+1.5%) to 41.059%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/host/internal/lib/ghw/ghw.go 3 6 50.0%
pkg/host/internal/lib/sriovnet/sriovnet.go 3 6 50.0%
pkg/host/internal/sriov/sriov.go 18 22 81.82%
Files with Coverage Reduction New Missed Lines %
controllers/generic_network_controller.go 5 74.53%
Totals Coverage Status
Change from base Build 9203023396: 1.5%
Covered Lines: 5334
Relevant Lines: 12991
💛 - Coveralls

SchSeba
SchSeba reviewed May 2, 2024
View reviewed changes
Copy link
Collaborator

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work, please just implement a small unit test to validate the return of the representor

pkg/host/internal/sriov/sriov_test.go Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@github-actions GitHub Actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@ykulazhenkov
Report VF representor name in the status field
700ca02 
Add support for reporting VF representor
name when the NIC is in switchev mode

Signed-off-by: Yury Kulazhenkov <ykulazhenkov@nvidia.com>
@ykulazhenkov
Add test for sriov.DiscoverSriovDevices function
808907f 
Signed-off-by: Yury Kulazhenkov <ykulazhenkov@nvidia.com>
@github-actions GitHub Actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@ykulazhenkov
Copy link
Collaborator Author

I rebased the PR and applied requested changes to the code. @SchSeba please take another look, thx

SchSeba
SchSeba approved these changes Jun 2, 2024
View reviewed changes
Copy link
Collaborator

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

/hold
waiting for the sriov operator release

ykulazhenkov
ykulazhenkov commented Jun 24, 2024
View reviewed changes
Copy link
Collaborator Author

@ykulazhenkov ykulazhenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SchSeba @adrianchiris The new version of the operator has been released. Can we merge this PR? thx

@adrianchiris adrianchiris merged commit 19b4cb6 into k8snetworkplumbingwg:master Jun 25, 2024
12 checks passed
@ykulazhenkov ykulazhenkov deleted the pr-report-representor branch June 25, 2024 12:59
zeeke added a commit to zeeke/sriov-network-operator-1 that referenced this pull request Jun 25, 2024
@zeeke
Fix undefined: pciAddr
ebdf4c5 
Merge issue coming from
- k8snetworkplumbingwg#690
- k8snetworkplumbingwg#587

Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
@zeeke zeeke mentioned this pull request Jun 25, 2024
Merged
zeeke added a commit to zeeke/sriov-network-operator-1 that referenced this pull request Jun 25, 2024
@zeeke
Fix undefined: pciAddr
c7c1edb 
Merge issue coming from
- k8snetworkplumbingwg#690
- k8snetworkplumbingwg#587

Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
maze88 pushed a commit to Mellanox/sriov-network-operator that referenced this pull request Jul 2, 2024
@zeeke @maze88
Fix undefined: pciAddr
9d53c18 
Merge issue coming from
- k8snetworkplumbingwg#690
- k8snetworkplumbingwg#587

Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SchSeba SchSeba SchSeba approved these changes

@adrianchiris adrianchiris adrianchiris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ykulazhenkov @coveralls @SchSeba @adrianchiris