[software-bridges 3/x] Add bridge package #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Pull Request Test Coverage Report for Build 9958277243Details
💛 - Coveralls |
SchSeba
reviewed
May 6, 2024
| CreateOVSBridge(ctx context.Context, conf *sriovnetworkv1.OVSConfigExt) error | ||
| // GetOVSBridges returns configuration for all managed bridges | ||
| GetOVSBridges(ctx context.Context) ([]sriovnetworkv1.OVSConfigExt, error) | ||
| // RemoveOVSBridge removes managed OVS bridge by name |
There was a problem hiding this comment.
do we also want/need getOVSBridge(name string)?
There was a problem hiding this comment.
This is not required by the implementation at the moment. I don't want to add this function just for API fullness
pkg/host/internal/bridge/ovs/ovs.go
Outdated
| // if OVS bridge exist with different config it will be removed and re-created | ||
| func (o *ovs) CreateOVSBridge(ctx context.Context, conf *sriovnetworkv1.OVSConfigExt) error { | ||
| ctx, cFunc := setDefaultTimeout(ctx) | ||
| defer cFunc() |
There was a problem hiding this comment.
nit: can you change cFunc to just cancel please ;)
pkg/host/internal/bridge/ovs/ovs.go
Outdated
| return nil | ||
| } | ||
|
|
||
| // RemoveInterfaceFromOVSBridge interface from the managed OVS bridge |
There was a problem hiding this comment.
please add: removes interface from the managed OVS bridge
pkg/host/internal/bridge/ovs/ovs.go
Outdated
| } | ||
|
|
||
| // RemoveInterfaceFromOVSBridge interface from the managed OVS bridge | ||
| func (o *ovs) RemoveInterfaceFromOVSBridge(ctx context.Context, ifaceAddr string) error { |
There was a problem hiding this comment.
ifaceAddr -> pciAddress it looks like it's ip address
pkg/host/internal/bridge/ovs/ovs.go
Outdated
| func (o *ovs) RemoveInterfaceFromOVSBridge(ctx context.Context, ifaceAddr string) error { | ||
| ctx, cFunc := setDefaultTimeout(ctx) | ||
| defer cFunc() | ||
| funcLog := log.Log.WithValues("ifaceAddr", ifaceAddr) |
There was a problem hiding this comment.
same here ifaceAddr -> pciAddress
pkg/host/internal/bridge/ovs/ovs.go
Outdated
| } | ||
|
|
||
| // delete bridge by the name | ||
| func (o *ovs) deleteBridge(ctx context.Context, dbClient client.Client, brName string) error { |
pkg/host/internal/bridge/ovs/ovs.go
Outdated
| } | ||
|
|
||
| // delete interface by the name | ||
| func (o *ovs) deleteInterface(ctx context.Context, dbClient client.Client, ifaceName string) error { |
|
partial review for now. added a few comments :) |
ykulazhenkov
force-pushed
the
pr-bridge-package
branch
from
cdec0b4
to
095dcb4
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
|
@adrianchiris @SchSeba thanks for your reviews! I addressed your comments. PTAL |
ykulazhenkov
force-pushed
the
pr-bridge-package
branch
from
095dcb4
to
51697bf
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
|
PR reabased. Currently it has no dependencies from other PRs |
ykulazhenkov
force-pushed
the
pr-bridge-package
branch
from
51697bf
to
e4b4f24
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
ykulazhenkov
force-pushed
the
pr-bridge-package
branch
from
e4b4f24
to
6d0b303
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
|
The PR rebased. @SchSeba I think all comments are addressed. Can you take another look? Thanks |
|
@SchSeba can we merge this one ? |
ykulazhenkov
force-pushed
the
pr-bridge-package
branch
from
6d0b303
to
47724b7
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
zeeke
reviewed
Jul 16, 2024
The package contains logic to work with managed OVS bridges. // DiscoverBridges returns information about managed bridges on the host DiscoverBridges() (sriovnetworkv1.Bridges, error) // ConfigureBridge configure managed bridges for the host ConfigureBridges(bridgesSpec sriovnetworkv1.Bridges, bridgesStatus sriovnetworkv1.Bridges) error // DetachInterfaceFromManagedBridge detach interface from a managed bridge, // this step is required before applying some configurations to PF, e.g. changing of eSwitch mode. // The function detach interface from managed bridges only. DetachInterfaceFromManagedBridge(pciAddr string) error Signed-off-by: Yury Kulazhenkov <ykulazhenkov@nvidia.com>
ykulazhenkov
force-pushed
the
pr-bridge-package
branch
from
47724b7
to
a801939
Compare
|
@zeeke Thanks for the review. I addressed your comments. Please, take another look |
zeeke
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package contains logic to work with managed OVS bridges.
Context is Software bridge management feature