Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump controller-gen to v0.14.0 #692

Merged
merged 1 commit into from
May 1, 2024

Conversation

e0ne
Copy link
Collaborator

@e0ne e0ne commented Apr 29, 2024

Update to the newer version to omit issue [1].

[1] kubernetes-sigs/controller-tools#888

Update to the newer version to omit issue [1].

[1] kubernetes-sigs/controller-tools#888

Signed-off-by: Ivan Kolodiazhnyi <ikolodiazhny@nvidia.com>
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8884111117

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 70 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.04%) to 38.649%

Files with Coverage Reduction New Missed Lines %
api/v1/zz_generated.deepcopy.go 70 45.9%
Totals Coverage Status
Change from base Build 8819367666: 0.04%
Covered Lines: 4874
Relevant Lines: 12611

💛 - Coveralls

Copy link
Collaborator

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SchSeba SchSeba merged commit dbc06b5 into k8snetworkplumbingwg:master May 1, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants