[metrics 3/x] end-to-end tests #702

zeeke · 2024-05-22T14:11:13Z

Exposed metrics can be verified by scraping the prometheus
endpoint on the sriov-network-metrics-exporter pod.
Add a test that spawns an SR-IOV consuming pod and verifies
its receiving counter increase when the interface is pinged from
outside.

depends on:

[metrics 2/x] Configure Prometheus Operator #687

github-actions · 2024-05-22T14:11:29Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-05-22T14:12:24Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

coveralls · 2024-05-22T14:18:46Z

Pull Request Test Coverage Report for Build 9207813927

Details

62 of 90 (68.89%) changed or added relevant lines in 3 files are covered.
5 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.2%) to 39.842%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
controllers/helper.go	13	17	76.47%
pkg/utils/cluster.go	11	19	57.89%
controllers/sriovoperatorconfig_controller.go	38	54	70.37%

Files with Coverage Reduction	New Missed Lines	%
controllers/generic_network_controller.go	5	74.53%

Totals
Change from base Build 9203023396:	0.2%
Covered Lines:	5183
Relevant Lines:	13009

💛 - Coveralls

github-actions · 2024-05-22T14:21:13Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-05-22T14:36:28Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-05-22T15:31:03Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-05-22T17:21:02Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-05-22T17:21:59Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-05-23T01:51:44Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-05-23T12:18:04Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

SchSeba · 2024-05-31T13:04:10Z

test/conformance/tests/test_exporter_metrics.go

+var _ = Describe("[sriov] Metrics Exporter", Ordered, func() {
+
+	BeforeAll(func() {
+		if cluster.VirtualCluster() {


I think this one needs to be in the beforeEach no? if we have multiple tests only the first one will get skipped?

Not with ginkgo v2:

In ginkgo v1 there was no BeforeAll, and we invented our own version of it

sriov-network-operator/test/util/execute/ginkgo.go

Lines 7 to 15 in 6b9f1c2

func BeforeAll(fn func()) {

first := true

ginkgo.BeforeEach(func() {

if first {

first = false

fn()

}

})

}

which has the "test skip" problem.

Ginkgo v2 BeforeAll can handle test skips, though it can be used in Ordered containers only.

SchSeba · 2024-06-03T11:14:54Z

test/conformance/tests/test_exporter_metrics.go

+
+	metricsExporterPod := metricsExporterPods.Items[0]
+
+	command := []string{"wget", "-qO-", "http://127.0.0.1:9110/metrics"}


please switch this one to curl as in the ubi images we don't have wget

Trying to pull registry.redhat.io/ubi9/ubi:latest... Getting image source signatures Checking if image destination supports signatures Copying blob bb65efb0bec6 done Copying config 02eedf8dcc done Writing manifest to image destination Storing signatures [root@d7d4fbbaf778 /]# wget bash: wget: command not found [root@d7d4fbbaf778 /]# curl curl: try 'curl --help' for more information

sure! no problem!

SchSeba · 2024-06-03T11:21:36Z

test/conformance/tests/test_exporter_metrics.go

+		finalRxPackets := getCounterForPod(finalMetrics, pod, "sriov_vf_rx_packets")
+
+		Expect(finalRxBytes).Should(BeNumerically(">", initialRxBytes))
+		Expect(finalRxPackets).Should(BeNumerically(">", initialRxPackets+3))


why you add the +3 here?

Because pingPod(...) function sends 3 ICMP packets

sriov-network-operator/test/conformance/tests/test_sriov_operator.go

Lines 2652 to 2669 in a8476f0

func pingPod(ip string, nodeSelector string, sriovNetworkAttachment string) {

ipProtocolVersion := "6"

if len(strings.Split(ip, ".")) == 4 {

ipProtocolVersion = "4"

}

podDefinition := pod.RedefineWithNodeSelector(

pod.RedefineWithCapabilities(

pod.RedefineWithRestartPolicy(

pod.RedefineWithCommand(

pod.DefineWithNetworks([]string{sriovNetworkAttachment}),

[]string{"sh", "-c", fmt.Sprintf("ping -%s -c 3 %s", ipProtocolVersion, ip)}, []string{},

),

corev1.RestartPolicyNever,

),

[]corev1.Capability{"NET_RAW"},

),

nodeSelector,

)

I could refactor that function a bit to make this information more explicit

Package `github.com/prometheus-operator/prometheus-operator/pkg/client` can be used for testing purpose. Signed-off-by: Andrea Panattoni <apanatto@redhat.com>

Signed-off-by: Andrea Panattoni <apanatto@redhat.com>

Deploy the needed configuration to make the prometheus operator to find and scrape the sriov-network-metrics-exporter endpoints, including the ServiceMonitor, Role and RoleBinding. Resources are installed only if the Prometheus operator is installed. Signed-off-by: Andrea Panattoni <apanatto@redhat.com>

github-actions · 2024-07-05T13:48:19Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

Exposed metrics can be verified by scraping the prometheus endpoint on the `sriov-network-metrics-exporter` pod. Add a test that spawns an SR-IOV consuming pod and verifies its receiving counter increase when the interface is pinged from outside. Signed-off-by: Andrea Panattoni <apanatto@redhat.com>

github-actions · 2024-07-05T13:59:26Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

zeeke force-pushed the metrics-exporter-test branch from 4ae399a to 87f725c Compare May 22, 2024 14:12

zeeke force-pushed the metrics-exporter-test branch from 87f725c to 2e4cab8 Compare May 22, 2024 14:21

zeeke force-pushed the metrics-exporter-test branch from 2e4cab8 to f824a33 Compare May 22, 2024 14:36

zeeke force-pushed the metrics-exporter-test branch from f824a33 to f11ade3 Compare May 22, 2024 15:30

zeeke force-pushed the metrics-exporter-test branch from f11ade3 to 20d2790 Compare May 22, 2024 17:20

zeeke force-pushed the metrics-exporter-test branch from 20d2790 to af25c1b Compare May 22, 2024 17:21

zeeke force-pushed the metrics-exporter-test branch from af25c1b to 9e21801 Compare May 23, 2024 01:51

zeeke force-pushed the metrics-exporter-test branch from 9e21801 to 35b5ded Compare May 23, 2024 12:17

zeeke mentioned this pull request May 23, 2024

[metrics 1/x] Support sriov-network-metrics-exporter #655

Merged

SchSeba reviewed Jun 3, 2024

View reviewed changes

zeeke added 3 commits July 3, 2024 11:19

Add prometheus-operator/pkg/client dependency

9c1eb96

Package `github.com/prometheus-operator/prometheus-operator/pkg/client` can be used for testing purpose. Signed-off-by: Andrea Panattoni <apanatto@redhat.com>

Add a non namespaced client to SriovOperatorConfigReconciler

11d6708

Signed-off-by: Andrea Panattoni <apanatto@redhat.com>

zeeke force-pushed the metrics-exporter-test branch from 35b5ded to a8476f0 Compare July 5, 2024 13:48

zeeke force-pushed the metrics-exporter-test branch from a8476f0 to ae75722 Compare July 5, 2024 13:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[metrics 3/x] end-to-end tests #702

[metrics 3/x] end-to-end tests #702

zeeke commented May 22, 2024 •

edited

Loading

github-actions bot commented May 22, 2024

github-actions bot commented May 22, 2024

coveralls commented May 22, 2024 •

edited

Loading

github-actions bot commented May 22, 2024

github-actions bot commented May 22, 2024

github-actions bot commented May 22, 2024

github-actions bot commented May 22, 2024

github-actions bot commented May 22, 2024

github-actions bot commented May 23, 2024

github-actions bot commented May 23, 2024

SchSeba May 31, 2024

zeeke Jul 5, 2024

SchSeba Jun 3, 2024

zeeke Jul 5, 2024

SchSeba Jun 3, 2024

zeeke Jul 5, 2024

github-actions bot commented Jul 5, 2024

github-actions bot commented Jul 5, 2024

	func BeforeAll(fn func()) {
	first := true
	ginkgo.BeforeEach(func() {
	if first {
	first = false
	fn()
	}
	})
	}


		metricsExporterPod := metricsExporterPods.Items[0]

		command := []string{"wget", "-qO-", "http://127.0.0.1:9110/metrics"}

	func pingPod(ip string, nodeSelector string, sriovNetworkAttachment string) {
	ipProtocolVersion := "6"
	if len(strings.Split(ip, ".")) == 4 {
	ipProtocolVersion = "4"
	}
	podDefinition := pod.RedefineWithNodeSelector(
	pod.RedefineWithCapabilities(
	pod.RedefineWithRestartPolicy(
	pod.RedefineWithCommand(
	pod.DefineWithNetworks([]string{sriovNetworkAttachment}),
	[]string{"sh", "-c", fmt.Sprintf("ping -%s -c 3 %s", ipProtocolVersion, ip)}, []string{},
	),
	corev1.RestartPolicyNever,
	),
	[]corev1.Capability{"NET_RAW"},
	),
	nodeSelector,
	)

[metrics 3/x] end-to-end tests #702

Are you sure you want to change the base?

[metrics 3/x] end-to-end tests #702

Conversation

zeeke commented May 22, 2024 • edited Loading

github-actions bot commented May 22, 2024

github-actions bot commented May 22, 2024

coveralls commented May 22, 2024 • edited Loading

Pull Request Test Coverage Report for Build 9207813927

Details

💛 - Coveralls

github-actions bot commented May 22, 2024

github-actions bot commented May 22, 2024

github-actions bot commented May 22, 2024

github-actions bot commented May 22, 2024

github-actions bot commented May 22, 2024

github-actions bot commented May 23, 2024

github-actions bot commented May 23, 2024

SchSeba May 31, 2024

Choose a reason for hiding this comment

zeeke Jul 5, 2024

Choose a reason for hiding this comment

SchSeba Jun 3, 2024

Choose a reason for hiding this comment

zeeke Jul 5, 2024

Choose a reason for hiding this comment

SchSeba Jun 3, 2024

Choose a reason for hiding this comment

zeeke Jul 5, 2024

Choose a reason for hiding this comment

github-actions bot commented Jul 5, 2024

github-actions bot commented Jul 5, 2024

zeeke commented May 22, 2024 •

edited

Loading

coveralls commented May 22, 2024 •

edited

Loading