Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release chart update #714

Merged

Conversation

adrianchiris
Copy link
Collaborator

refer to individual commits for more context.

gist:

  • set correct ovs cni image
  • fix operator name in chart

container image is named ovs-cni-plugin and not ovs-cni

Signed-off-by: adrianc <adrianc@nvidia.com>
update default values of the following vars:
- sriov-network-operator.name
- sriov-network-operator.fullname

use value "sriov-network-operator" instead of chart name
which is now "sriov-network-operator-chart" to avoid wierd
naming of the operator deployment e.g:

sriov-network-operator-sriov-network-operator-chart

this change will keep the same naming convention as it was
before changing the chart name from sriov-network-operator
to sriov-network-operator-chart

Signed-off-by: adrianc <adrianc@nvidia.com>
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

coveralls commented Jun 16, 2024

Pull Request Test Coverage Report for Build 9535828074

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 38.645%

Totals Coverage Status
Change from base Build 9535506798: 0.0%
Covered Lines: 5180
Relevant Lines: 13404

💛 - Coveralls

Copy link
Collaborator

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SchSeba SchSeba merged commit 689d7ed into k8snetworkplumbingwg:master Jun 16, 2024
12 of 13 checks passed
@adrianchiris adrianchiris deleted the fix-release-chart-update branch July 16, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants