e2e: Verify removing partial policy works #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Pull Request Test Coverage Report for Build 9567867714Details
💛 - Coveralls |
zeeke
force-pushed
the
drain-loop-vfio-pci-e2e
branch
from
7903ee8
to
3e43dfe
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Pull Request Test Coverage Report for Build 10009093796Details
💛 - Coveralls |
zeeke
force-pushed
the
drain-loop-vfio-pci-e2e
branch
from
3e43dfe
to
9873c9a
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
zeeke
force-pushed
the
drain-loop-vfio-pci-e2e
branch
from
9873c9a
to
3de63d6
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
SchSeba
reviewed
Jul 11, 2024
| var sriovInfos *cluster.EnabledNodes | ||
|
|
||
| BeforeAll(func() { | ||
| isSingleNode, err := cluster.IsSingleNode(clients) |
There was a problem hiding this comment.
this is the same as in the other file can we just have an internal function that will call BeforeAll?
There was a problem hiding this comment.
I refactored to a common BeforeSuite section. It's the best we can do IMO because these BeforeAll sections modify shared variables. WDYT?
| WaitForSRIOVStable() | ||
|
|
||
| By("waiting for the resources to be available") | ||
| Eventually(func() int64 { |
There was a problem hiding this comment.
not specially to this PR but can you create a function for this we use it in multiple places already?
There was a problem hiding this comment.
Refactored to a common waitForPodRunning(...). Got rid of a lot of code
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
zeeke
force-pushed
the
drain-loop-vfio-pci-e2e
branch
from
b0d9977
to
da8a59f
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
zeeke
force-pushed
the
drain-loop-vfio-pci-e2e
branch
from
da8a59f
to
789af14
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
zeeke
force-pushed
the
drain-loop-vfio-pci-e2e
branch
from
789af14
to
8032e93
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
zeeke
force-pushed
the
drain-loop-vfio-pci-e2e
branch
from
8032e93
to
7fa2b8b
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
zeeke
force-pushed
the
drain-loop-vfio-pci-e2e
branch
from
7fa2b8b
to
774d7ca
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
|
can you please take a look on the CI they both failed on the same test |
zeeke
force-pushed
the
drain-loop-vfio-pci-e2e
branch
from
774d7ca
to
0286da5
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
…n file To improve readability, reduce the sizeof `test_sriov_operator.go` by moving part of the test cases to a different file. It's important to keep the same test name, which are composed by the combination of each parent `Context`/`Describe`/`It` clause. Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
Add an end-to-end test to verify removing a partial SriovNetworkNodePolicy does not trigger any issue in the operator's deployment. Refs: - https://issues.redhat.com/browse/OCPBUGS-34934 - k8snetworkplumbingwg#710 Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
Move the device discovery and `BeforeAll` checks in the `BeforeSuite` section of the test suite. Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
zeeke
force-pushed
the
drain-loop-vfio-pci-e2e
branch
from
0286da5
to
32123e1
Compare
adrianchiris
approved these changes
Jul 31, 2024
|
This PR got approval from different sides. Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an end-to-end test to verify removing a partial
SriovNetworkNodePolicy does not trigger any issue in
the operator's deployment.
Refs:
This PR also contains a refactor of the conformance test suite