Round up MaxUnavailable to 1 node instead of 0 #730
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
When MaxUnavailable is configured as percent and cluster is too small we need to roundup MaxUnavailable count to 1 instead of 0 to get draining working. Signed-off-by: Ivan Kolodiazhnyi <ikolodiazhny@nvidia.com>
e0ne
force-pushed
the
round-up-max-unavailable
branch
from
38ee3be
to
262a805
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Pull Request Test Coverage Report for Build 9810045968Details
💛 - Coveralls |
ykulazhenkov
previously approved these changes
Jul 5, 2024
adrianchiris
approved these changes
Jul 9, 2024
|
After discussion in the meeting we decided that it works as designed. We can't set |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When MaxUnavailable is configured as percent and cluster is too small we need to roundup MaxUnavailable count to 1 instead of 0 to get draining working.