New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[metrics 4/x] Metrics exporter rules #732

Open

zeeke wants to merge 1 commit into k8snetworkplumbingwg:master from zeeke:metrics-exporter-rules

+265 −3

Member

zeeke commented Jul 10, 2024 •

edited

Loading

PrometheusRules allow recording pre-defined queries. Use
sriov_kubepoddevice metric to add pod|namespace pair
to the sriov metrics.

Here is an example of the raw exported metrics:

sriov_kubepoddevice{container="testpmd",dev_type="openshift.io/inteldpdk",namespace="cnf-4916",pciAddr="0000:17:01.4",pod="dpdk-intel-client"} 1

sriov_vf_rx_broadcast{numa_node="0",pciAddr="0000:17:01.4",pf="ens2f0",vf="4"} 1.0926018e+07
sriov_vf_rx_bytes{numa_node="0",pciAddr="0000:17:01.4",pf="ens2f0",vf="4"} 7.83952134e+08
sriov_vf_rx_dropped{numa_node="0",pciAddr="0000:17:01.4",pf="ens2f0",vf="4"} 0
sriov_vf_rx_multicast{numa_node="0",pciAddr="0000:17:01.4",pf="ens2f0",vf="4"} 0
sriov_vf_rx_packets{numa_node="0",pciAddr="0000:17:01.4",pf="ens2f0",vf="4"} 1.0926018e+07
sriov_vf_tx_bytes{numa_node="0",pciAddr="0000:17:01.4",pf="ens2f0",vf="4"} 0
sriov_vf_tx_dropped{numa_node="0",pciAddr="0000:17:01.4",pf="ens2f0",vf="4"} 1.0926018e+07
sriov_vf_tx_packets{numa_node="0",pciAddr="0000:17:01.4",pf="ens2f0",vf="4"} 0

Proposed prometheus rules allow to query the following new metrics:

network:sriov_vf_tx_packets
network:sriov_vf_rx_packets
network:sriov_vf_tx_bytes
network:sriov_vf_rx_bytes
network:sriov_vf_tx_dropped
network:sriov_vf_rx_dropped
network:sriov_vf_rx_broadcast
network:sriov_vf_rx_multicast

github-actions bot commented Jul 10, 2024

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

zeeke force-pushed the metrics-exporter-rules branch from e1551a6 to 86719de Compare

July 10, 2024 15:53

github-actions bot commented Jul 10, 2024

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

zeeke force-pushed the metrics-exporter-rules branch from 86719de to 0069e5e Compare

July 11, 2024 08:00

github-actions bot commented Jul 11, 2024

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

zeeke force-pushed the metrics-exporter-rules branch from 0069e5e to fed3f8c Compare

July 11, 2024 09:58

github-actions bot commented Jul 11, 2024

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

zeeke force-pushed the metrics-exporter-rules branch from fed3f8c to 5ba65f8 Compare

July 15, 2024 10:59

github-actions bot commented Jul 15, 2024

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

zeeke force-pushed the metrics-exporter-rules branch from 5ba65f8 to 5b085ea Compare

July 15, 2024 12:16

github-actions bot commented Jul 15, 2024

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

zeeke force-pushed the metrics-exporter-rules branch 4 times, most recently from 3eced4d to 7b25cc6 Compare

July 19, 2024 13:58

zeeke force-pushed the metrics-exporter-rules branch from 7b25cc6 to f004d91 Compare

August 5, 2024 11:16

zeeke marked this pull request as ready for review

August 5, 2024 11:17

coveralls commented Aug 5, 2024 •

edited

Loading

Pull Request Test Coverage Report for Build 10470789795

Details

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 45.01%

Totals
Change from base Build 10454628601:	0.01%
Covered Lines:	6535
Relevant Lines:	14519

💛 - Coveralls

adrianchiris reviewed

View reviewed changes

bindata/manifests/metrics-exporter/metrics-prometheus-rule.yaml Outdated

		@@ -0,0 +1,38 @@
		---
		{{ if .IsPrometheusOperatorInstalled }}

Collaborator

adrianchiris Aug 12, 2024

i recall we discussed having a separate env var for deploying rules right ?

from aug 06 2024 meeting notes:

Adding a new env variable to decide if deploy prometheus rules

Member Author

zeeke Aug 19, 2024

yes, I'm fixing that

zeeke force-pushed the metrics-exporter-rules branch 2 times, most recently from 2504fcd to d8ce5ef Compare

August 20, 2024 11:17


          metrics: Add PrometheusRule for namespaced metrics

9493e50

PrometheusRules allow recording pre-defined queries. Use
`sriov_kubepoddevice` metric to add `pod|namespace` pair
to the sriov metrics.

Feature is enabled via the `METRICS_EXPORTER_PROMETHEUS_DEPLOY_RULE`
environment variable.

Signed-off-by: Andrea Panattoni <apanatto@redhat.com>

zeeke force-pushed the metrics-exporter-rules branch from d8ce5ef to 9493e50 Compare

August 20, 2024 11:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment