-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: sent ci-triggers comment only once on PR open or reopen #737
ci: sent ci-triggers comment only once on PR open or reopen #737
Conversation
Thanks for your PR,
To skip the vendors CIs use one of:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
0a7f458
to
7f3c087
Compare
Thanks for your PR,
To skip the vendors CIs use one of:
|
Pushed a new HEAD to the branch but the bot is still commenting the ci-triggers list. According to https://docs.github.com/en/actions/using-workflows/triggering-a-workflow:
So this should work 🤔 |
This might explain why it is not working:
|
Ah, that explains it. So we have 2 options:
WDYT? Edit: IMO is |
7f3c087
to
a0033f6
Compare
Thanks for your PR,
To skip the vendors CIs use one of:
|
... but sure, simply changing it to |
If we specify a type we can stop the Github Actions bot from resending the ci-triggers list to open PRs on every HEAD change. > [...] if no activity types are specified, the workflow runs when a pull request is opened or reopened or when the head branch of the pull request is updated. Signed-off-by: Tobias Giese <tgiese@nvidia.com>
a0033f6
to
ee7a04a
Compare
Thanks for your PR,
To skip the vendors CIs use one of:
|
Pull Request Test Coverage Report for Build 9954046539Details
💛 - Coveralls |
It is way simpler to merge this, test it in another PR, and create a revert PR if the final situation is worse than the actual one. |
merging :) |
If we specify a type we can stop the Github Actions bot from resending the
ci-triggers list to open PRs on every HEAD change.
source: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target