Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor some conformance tests to use SRIOV_NODE_AND_DEVICE_NAME_FILTER #771

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

zeeke
Copy link
Member

@zeeke zeeke commented Sep 4, 2024

This commit updates several conformance tests to make use of the SRIOV_NODE_AND_DEVICE_NAME_FILTER variable. By integrating this variable, the tests can now better target specific nodes and devices, improving test precision and reducing potential errors. This change enhances the flexibility and maintainability of the test suite.

cc @evgenLevin

Copy link

github-actions bot commented Sep 4, 2024

Thanks for your PR,
To run vendors CIs, Maintainers can use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs, Maintainers can use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10696494272

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 44.981%

Totals Coverage Status
Change from base Build 10683587415: 0.0%
Covered Lines: 6600
Relevant Lines: 14673

💛 - Coveralls

@zeeke
Copy link
Member Author

zeeke commented Sep 12, 2024

@SchSeba @ykulazhenkov can you please take a look?

Copy link
Collaborator

@adrianchiris adrianchiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adrianchiris
Copy link
Collaborator

@zeeke feel free to self merge this one if you are happpy with it

@zeeke
Copy link
Member Author

zeeke commented Sep 19, 2024

@zeeke feel free to self merge this one if you are happpy with it

thanks! Merging

@zeeke zeeke merged commit 60c6404 into k8snetworkplumbingwg:master Sep 19, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants