Skip to content

Commit

Permalink
Safer reconciler spec (#167)
Browse files Browse the repository at this point in the history
* reconciler, spec: forbid concurrent executions

Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>

* reconciler, spec: remove complete pods

We leave the default `failedJobsHistoryLimit` - 1 - to enable the
user to debug the reconciler in case it fails.

Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>

* reconciler, spec: do not retry on error

Since a new pod will be scheduled in 5 minutes, it is safer to just
wait for the new reconcile cycle than insist on reconciling right
now.

This is important to prevent the cluster to clog further on
constrained clusters.

Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
  • Loading branch information
maiqueb committed Nov 29, 2021
1 parent 2b15ccc commit abd29e8
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions doc/crds/ip-reconciler-job.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,12 @@ metadata:
tier: node
app: whereabouts
spec:
concurrencyPolicy: Forbid
successfulJobsHistoryLimit: 0
schedule: "*/5 * * * *"
jobTemplate:
spec:
backoffLimit: 0
template:
metadata:
labels:
Expand Down

0 comments on commit abd29e8

Please sign in to comment.