move install-cni.sh to an initContainer #251
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maiqueb
requested changes
Jul 18, 2022
There was a problem hiding this comment.
I think this PR improves the code base, and I agree we should be using the K8s primitives to get required stuff installed in the nodes.
... having said that, once we have this in an init container, it doesn't make sense to have that ugly bash script a long lived process. I think you should remove the SLEEP option from it, and just make it a one-shot script.
Thanks for spotting this and for following through with a PR.
|
happy to add that to this PR
…On Mon, Jul 18, 2022, 04:38 Miguel Duarte Barroso ***@***.***> wrote:
***@***.**** requested changes on this pull request.
I think this PR improves the code base, and I agree we should be using the
K8s primitives to get required stuff installed in the nodes.
... having said that, once we have this in an init container, it doesn't
make sense to have that ugly bash script a long lived process. I think you
should remove the SLEEP option from it, and just make it a one-shot
script.
Thanks for spotting this and for following through with a PR.
—
Reply to this email directly, view it on GitHub
<#251 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA36GX3FXNMIJDP3LT2JJR3VUU645ANCNFSM532NIHCA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
maiqueb
approved these changes
Jul 18, 2022
- quote all the things - remove some bits that aren't POSIX but busybox sh supports, to make shellcheck happy - make chown modes absolute
|
e2e CI failed, I'll look into it
https://github.com/k8snetworkplumbingwg/whereabouts/runs/7391864197?check_suite_focus=true
…--
regards,
DQ
On Mon, Jul 18, 2022, 07:46 Miguel Duarte Barroso ***@***.***> wrote:
***@***.**** approved this pull request.
Thanks.
Let see what the other maintainers think of this ...
—
Reply to this email directly, view it on GitHub
<#251 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA36GXZJ2LBMNTF3NTDSX6DVUVU4XANCNFSM532NIHCA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Where do we stand with this PR? I was about to submit something similar, but this one seems stuck |
|
@deekue mind rebasing this PR so we see how this behaves in regard to the e2e tests ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
install-cni.shto an initContainer. separation of concernsip-control-loopdirectly. daemon receives signals from k8s for graceful shutdown etc