Migrations to golang 1.19 #271
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # cmd/suite_test.go # go.sum # pkg/reconciler/suite_test.go
maiqueb
requested changes
Oct 5, 2022
There was a problem hiding this comment.
It's confusing to see the PR structured as is: multiple times a commit is just fixing something which was broken in a previous commit.
This makes the reviewers life harder, and renders tools like git bisect useless if this happens to be merged.
Could you please squash everything into a single commit - or structure the commits in a better way ?
Finally, I wonder if we should jump to 1.19 now. I personally would only do it once 1.18 goes EOL - meaning, I think the project's go.mod should use the oldest supported version of golang.
Pull Request Test Coverage Report for Build 3188704025
💛 - Coveralls |
|
@kmlebedev any chance you can rebase? We can take another look at moving to 1.19 thanks for the PR |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
migrations to golang 1.19