Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor fix: update comment in whereabouts cni kubeconfig #327

Merged
merged 1 commit into from
May 26, 2023
Merged

minor fix: update comment in whereabouts cni kubeconfig #327

merged 1 commit into from
May 26, 2023

Conversation

tariq1890
Copy link
Contributor

What this PR does / why we need it:
Probably a copypasta from multus-cni. Fixed comments to reflect purpose of generated kubeconfig

@tariq1890 tariq1890 requested a review from dougbtv as a code owner May 3, 2023 03:31
@tariq1890
Copy link
Contributor Author

@dougbtv Can you review this?

@dougbtv dougbtv merged commit d15b4d5 into k8snetworkplumbingwg:master May 26, 2023
@dougbtv
Copy link
Member

dougbtv commented May 26, 2023

Thanks Tariq!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4868037006

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.095%
Totals Coverage Status
Change from base Build 4721797056: 0.0%
Covered Lines: 974
Relevant Lines: 1351
💛 - Coveralls

@tariq1890 tariq1890 deleted the update-kubecfg branch May 26, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbtv dougbtv dougbtv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tariq1890 @dougbtv @coveralls