IterateForAssignment: Properly handle invalid syntax for exclude range #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correctly handle errors from parsing exclude ranges to avoid issues with nil pointer exceptions. Parse single IP addresses such as 192.168.123.10 or fe02::10 and convert them to CIDRs by appending the correct prefix. Signed-off-by: Andreas Karis <ak.karis@gmail.com>
andreaskaris
force-pushed
the
nil-pointer-exclude-range
branch
from
db057b9
to
e29384d
Compare
dougbtv
approved these changes
Jul 21, 2023
| if ip.To4() != nil { | ||
| _, subnet, err = net.ParseCIDR(fmt.Sprintf("%s/32", s)) | ||
| } else { | ||
| _, subnet, err = net.ParseCIDR(fmt.Sprintf("%s/128", s)) |
There was a problem hiding this comment.
Yep, I'm into this approach of adding the suffix if it's a single IP, nice call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly handle errors from parsing exclude ranges to avoid issues with nil pointer exceptions.
Parse single IP addresses such as 192.168.123.10 or fe02::10 by and convert them to CIDRs by appending the correct
prefix.
Fixes #364
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer (optional):