Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump net-attach to v1.7 #452

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

manuelbuil
Copy link
Collaborator

What this PR does / why we need it:

Bump network-attachment-definition-client to v1.7.0.

It requires moving to skel.PluginMainFuncs instead of skel.PluginMain

Error: cmd/whereabouts.go:21:2: skel.PluginMain is deprecated: Use github.com/containernetworking/cni/pkg/skel.PluginMainFuncs instead.  (SA1019)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer (optional):

@coveralls
Copy link

coveralls commented Apr 12, 2024

Pull Request Test Coverage Report for Build 8689302289

Details

  • 0 of 35 (0.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.4%) to 71.99%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/whereabouts.go 0 35 0.0%
Files with Coverage Reduction New Missed Lines %
cmd/whereabouts.go 2 46.99%
Totals Coverage Status
Change from base Build 8689276647: -0.4%
Covered Lines: 1136
Relevant Lines: 1578

💛 - Coveralls

@manuelbuil manuelbuil requested a review from SchSeba April 12, 2024 13:27
Copy link

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Manuel Buil <mbuil@suse.com>
Signed-off-by: Manuel Buil <mbuil@suse.com>
@manuelbuil manuelbuil merged commit c599b3c into k8snetworkplumbingwg:master Apr 19, 2024
10 checks passed
@manuelbuil manuelbuil deleted the updatenetattach17 branch April 19, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants