Do not /start pods which are not supposed to be part of the cluster #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, not containerStatus (since it is not going to be started)
burmanm
force-pushed
the
fix_starting_phantom_nodes-cass-85
branch
from
281251f to
c4ea0e4
Compare
burmanm
force-pushed
the
fix_starting_phantom_nodes-cass-85
branch
from
c4ea0e4 to
c73a1ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
startAllNodes should only take into account nodes that are part of the desiredRackInformation. That way we don't start phantom nodes that were created by the StatefulSet controller are not supposed to be part of the Cassandra cluster itself.
This is what causes flakes with scale_down_unbalanced test.
Which issue(s) this PR fixes:
Fixes #744
Checklist