-
Notifications
You must be signed in to change notification settings - Fork 4
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix override-src-port and override-src-ip flag parsing in register co…
…mmand (#56) * Fix flag names as identified by Micke. * Add a test. * Fix test code, add more tests * Remove global variable RegisterClusterCmd --------- Co-authored-by: Michael Burman <yak@iki.fi>
- Loading branch information
1 parent
00b5fae
commit 39a6ddd
Showing
2 changed files
with
86 additions
and
22 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| package register | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| "github.com/spf13/cobra" | ||
| "github.com/stretchr/testify/require" | ||
| "k8s.io/cli-runtime/pkg/genericiooptions" | ||
| ) | ||
|
|
||
| func TestInputParameters(t *testing.T) { | ||
| require := require.New(t) | ||
|
|
||
| var executor *RegistrationExecutor | ||
|
|
||
| cmd := &cobra.Command{} | ||
| SetupRegisterClusterCmd(cmd, genericiooptions.NewTestIOStreamsDiscard()) | ||
| cmd.Commands()[0].RunE = func(cmd *cobra.Command, args []string) error { | ||
| executor = NewRegistrationExecutorFromRegisterClusterCmd(*cmd) | ||
| return nil | ||
| } | ||
| cmd.Root().SetArgs([]string{ | ||
| "register", | ||
| "--source-context", "source-ctx", | ||
| "--source-kubeconfig", "testsourcekubeconfig", | ||
| "--dest-kubeconfig", "testdestkubeconfig", | ||
| "--dest-context", "dest-ctx", | ||
| "--source-namespace", "source-namespace", | ||
| "--dest-namespace", "dest-namespace", | ||
| "--serviceaccount-name", "test-sa", | ||
| "--override-src-ip", "127.0.0.2", | ||
| "--override-src-port", "9999"}) | ||
|
|
||
| require.NoError(cmd.Execute()) | ||
|
|
||
| require.Equal("127.0.0.2", executor.OverrideSourceIP) | ||
| require.Equal("9999", executor.OverrideSourcePort) | ||
| require.Equal("testsourcekubeconfig", executor.SourceKubeconfig) | ||
| require.Equal("source-ctx", executor.SourceContext) | ||
| require.Equal("testdestkubeconfig", executor.DestKubeconfig) | ||
| require.Equal("dest-ctx", executor.DestContext) | ||
| require.Equal("source-namespace", executor.SourceNamespace) | ||
| require.Equal("dest-namespace", executor.DestNamespace) | ||
| require.Equal("test-sa", executor.ServiceAccount) | ||
| } | ||
|
|
||
| func TestIncorrectParameters(t *testing.T) { | ||
| require := require.New(t) | ||
|
|
||
| cmd := &cobra.Command{} | ||
| cmd.SilenceUsage = true | ||
| SetupRegisterClusterCmd(cmd, genericiooptions.NewTestIOStreamsDiscard()) | ||
| cmd.Commands()[0].RunE = func(cmd *cobra.Command, args []string) error { | ||
| return nil | ||
| } | ||
|
|
||
| cmd.Root().SetArgs([]string{ | ||
| "register", | ||
| "--service-account", "test-sa", | ||
| }) | ||
|
|
||
| err := cmd.Execute() | ||
| require.Error(err) | ||
| require.Equal("unknown flag: --service-account", err.Error()) | ||
| } |