Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UseZGC sets incorrect option order when used with JDK 11 #54

Closed
burmanm opened this issue Jul 15, 2024 · 2 comments · Fixed by #57
Closed

UseZGC sets incorrect option order when used with JDK 11 #54

burmanm opened this issue Jul 15, 2024 · 2 comments · Fixed by #57
Labels
done Issues in the state 'done'

Comments

@burmanm
Copy link
Collaborator

burmanm commented Jul 15, 2024

Bug is here:

k8ssandra-client/pkg/config/builder.go

Line 364 in 00b5fae

if jvmMajor < 17 {

We should set the options in different order when older JDK version is used.

Original ticket here: k8ssandra/k8ssandra-operator#1368
burmanm added a commit to burmanm/k8ssandra-client that referenced this issue Jul 15, 2024
@burmanm
Fix UseZGC parameter ordering when used with JDK 11, Fixes k8ssandra#54
87fa4ed
@burmanm burmanm moved this to Ready For Review in K8ssandra Jul 15, 2024
@adejanovski adejanovski added the ready-for-review Issues in the state 'ready-for-review' label Jul 15, 2024
@Miles-Garnsey
Copy link
Member

Miles-Garnsey commented Jul 18, 2024 •
edited
Loading

Hey Micke, you've referenced this issue in a commit, but I don't know what PR it belongs to. Can you share?

@burmanm burmanm mentioned this issue Jul 18, 2024
Merged
@burmanm
Copy link
Collaborator Author

burmanm commented Jul 18, 2024

Now linked from comment also. It was visible as # 54 in the PRs titles also.

@github-project-automation github-project-automation bot moved this from Ready For Review to Done in K8ssandra Jul 19, 2024
@adejanovski adejanovski added done Issues in the state 'done' and removed ready-for-review Issues in the state 'ready-for-review' labels Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
done Issues in the state 'done'
Projects
No open projects
K8ssandra
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix UseZGC parameter ordering when used with JDK 11, Fixes #54 burmanm/k8ssandra-client
3 participants
@burmanm @adejanovski @Miles-Garnsey