Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong keyspace replication factor alteration when multiple dcs with the same name exist #1189

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

adejanovski
Copy link
Contributor

What this PR does:
Uses a proper cluster label filter when listing pods.

Which issue(s) this PR fixes:
Fixes #1188

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CHANGELOG.md updated (not required for documentation PRs)
  • CLA Signed: DataStax CLA

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (651e3f7) 57.13% compared to head (792789d) 57.30%.
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1189      +/-   ##
==========================================
+ Coverage   57.13%   57.30%   +0.16%     
==========================================
  Files         103      103              
  Lines       10618    10618              
==========================================
+ Hits         6067     6085      +18     
+ Misses       4023     4008      -15     
+ Partials      528      525       -3     
Files Coverage Δ
pkg/cassandra/management.go 0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes

Copy link

sonarcloud bot commented Jan 30, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@adejanovski adejanovski marked this pull request as ready for review January 30, 2024 11:06
@adejanovski adejanovski requested a review from a team as a code owner January 30, 2024 11:06
@adejanovski adejanovski merged commit 43361ee into main Jan 30, 2024
61 of 62 checks passed
@adejanovski adejanovski deleted the fix-keyspace-alters branch January 30, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The operator keeps on altering keyspace replications at each reconcile
2 participants