ReplicatedSecrets can have a prefix per target

[Miles-Garnsey]

What this PR does:
Allow a ReplicatedSecret replication target to define a prefix to de-conflict instances where the same source may target the same target multiple times due to presence of several clusters in the target namespace.

Which issue(s) this PR fixes:
Fixes #1242

Checklist

• Changes manually tested
• Automated Tests added/updated
• Documentation added/updated
• CHANGELOG.md updated (not required for documentation PRs)
• CLA Signed: DataStax CLA

[Miles-Garnsey]

This ticket needs one additional thing. At present the final env test that I've added is failing, as the target secret (which has a prefix in this test) is not being properly deleted after it's source secret is deleted. I don't know quite where this logic is supposed to happen, so I've reached out to @burmanm for some help.

Everything else looks ok however.

[burmanm]

I don't know quite where this logic is supposed to happen

https://github.com/k8ssandra/k8ssandra-operator/blob/main/controllers/replication/secret_controller.go#L70

[Miles-Garnsey]

@burmanm the link you provided to the cleanup logic only seems to deal with the ReplicatedSecret resource:

I don't know quite where this logic is supposed to happen

https://github.com/k8ssandra/k8ssandra-operator/blob/main/controllers/replication/secret_controller.go#L70

I'm trying to figure out where the cleanup is that is triggered when the source secret is deleted.

[Miles-Garnsey]

I've discussed this with @burmanm and it appears that if a source secret is deleted without the replicatedSecret that references it being deleted, then actually the downstream secret that is produced by the ReplicatedSecret is not deleted.

At the moment we do have orphaned resources in a sense, so I will work with Micke to create a new ticket to address that. But this PR is good to go.

[codecov]

Codecov Report

Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 57.30%. Comparing base (94bc1d8) to head (0ac1d65).
Report is 3 commits behind head on main.

❗ Current head 0ac1d65 differs from pull request most recent head 54c2b51. Consider uploading reports for the commit 54c2b51 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1243      +/-   ##
==========================================
- Coverage   57.34%   57.30%   -0.05%     
==========================================
  Files         103      103              
  Lines       10790    10795       +5     
==========================================
- Hits         6188     6186       -2     
- Misses       4064     4069       +5     
- Partials      538      540       +2     

Files	Coverage Δ
controllers/replication/secret_controller.go	65.01% <85.71%> (+0.58%)	⬆️

... and 4 files with indirect coverage changes

[sonarcloud]

Quality Gate failed

Failed conditions
4.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud