Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Medusa bucket secret label #1262

Merged
merged 21 commits into from
Apr 12, 2024
Merged

Conversation

Miles-Garnsey
Copy link
Member

@Miles-Garnsey Miles-Garnsey commented Mar 27, 2024

What this PR does:

Which issue(s) this PR fixes:
Fixes #1253

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CHANGELOG.md updated (not required for documentation PRs)
  • CLA Signed: DataStax CLA

@Miles-Garnsey Miles-Garnsey requested a review from a team as a code owner March 27, 2024 03:22
@Miles-Garnsey
Copy link
Member Author

Miles-Garnsey commented Mar 27, 2024

A bunch of unit/integration test failures here, these don't happen locally so I'm not sure what the problem is. I'm assuming there's something wrong with main which is getting picked up in the pre-test rebase.

EDIT: nope just a flake...

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 59.09091% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 57.41%. Comparing base (c167256) to head (d21a4ef).
Report is 1 commits behind head on main.

❗ Current head d21a4ef differs from pull request most recent head 07c23c8. Consider uploading reports for the commit 07c23c8 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1262      +/-   ##
==========================================
- Coverage   57.43%   57.41%   -0.03%     
==========================================
  Files         103      103              
  Lines       10808    10823      +15     
==========================================
+ Hits         6208     6214       +6     
- Misses       4063     4072       +9     
  Partials      537      537              
Files Coverage Δ
apis/k8ssandra/v1alpha1/k8ssandracluster_types.go 43.20% <0.00%> (-1.10%) ⬇️
pkg/utils/hash.go 0.00% <0.00%> (ø)
...ntrollers/medusa/medusaconfiguration_controller.go 79.36% <76.47%> (-3.66%) ⬇️

... and 4 files with indirect coverage changes

@Miles-Garnsey Miles-Garnsey self-assigned this Apr 3, 2024
CHANGELOG/CHANGELOG-1.14.md Outdated Show resolved Hide resolved
@Miles-Garnsey Miles-Garnsey force-pushed the feature/medusa-bucket-secret-label branch from 1026351 to e71e35b Compare April 5, 2024 00:18
@Miles-Garnsey Miles-Garnsey force-pushed the feature/medusa-bucket-secret-label branch from 8539f67 to 2b69e44 Compare April 5, 2024 00:45
@Miles-Garnsey
Copy link
Member Author

This PR now

  • Also ensures that the system kustomize is not used for e2e tests, instead preferring the one installed in the ./bin directory.
  • It pins that kustomize back to a 4.x.x version to ensure that we can use namespace replacements as expected.
  • It fixes some issues in the makefile where the local bin dir was not being exported to subshells.
  • It changes the port used by the docker registry deployed by kind to 5001, which avoids conflicts with other services on recent MacOSes.
  • I've also added patch permissions for secrets, which was necessary to ensure that the update operation could happen.

It should be ready to go now and CI should be 100% green.

Makefile Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Apr 11, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@burmanm burmanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Followup in the #955

@Miles-Garnsey Miles-Garnsey merged commit b256c85 into main Apr 12, 2024
58 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a unique label to the Medusa bucket secret
2 participants