Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 4.x versions #797

Merged
merged 2 commits into from
Jan 3, 2023
Merged

Conversation

adejanovski
Copy link
Contributor

What this PR does:
Allows using 4.x versions (including the recently released 4.1.0).

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CHANGELOG.md updated (not required for documentation PRs)
  • CLA Signed: DataStax CLA

@adejanovski adejanovski requested a review from a team as a code owner December 15, 2022 07:12
@github-actions
Copy link

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2022

Codecov Report

Merging #797 (5691d9f) into main (5ac2c68) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #797      +/-   ##
==========================================
+ Coverage   55.92%   56.00%   +0.08%     
==========================================
  Files          88       88              
  Lines        8562     8562              
==========================================
+ Hits         4788     4795       +7     
+ Misses       3344     3339       -5     
+ Partials      430      428       -2     
Impacted Files Coverage Δ
apis/k8ssandra/v1alpha1/k8ssandracluster_types.go 32.46% <ø> (ø)
pkg/cassandra/datacenter.go 65.98% <ø> (ø)
controllers/stargate/stargate_controller.go 47.48% <0.00%> (+1.11%) ⬆️
controllers/k8ssandra/stargate.go 66.14% <0.00%> (+2.36%) ⬆️

Copy link
Contributor

@emerkle826 emerkle826 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adejanovski adejanovski merged commit 224e0e3 into k8ssandra:main Jan 3, 2023
adejanovski added a commit that referenced this pull request Jan 3, 2023
* Allow 4.x versions
* Revert e2e test to 4.0 and introduce release notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants