Enable smart token allocation by default for DSE #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #801 +/- ##
==========================================
- Coverage 56.18% 56.14% -0.04%
==========================================
Files 90 90
Lines 8761 8768 +7
==========================================
+ Hits 4922 4923 +1
- Misses 3399 3403 +4
- Partials 440 442 +2
|
adutra
approved these changes
Dec 20, 2022
adejanovski
force-pushed
the
enable-dse-token-allocation
branch
from
d3b3bb1
to
20645fc
Compare
adejanovski
force-pushed
the
enable-dse-token-allocation
branch
from
20645fc
to
ce689b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
DSE cassandra.yaml file doesn't set a default value for
allocate_tokens_for_local_replication_factorand thus disables smart allocations by default.This PR will enable it for DSE, using the same defaults as C* 4.x, while preserving any override from users.
Which issue(s) this PR fixes:
Fixes #796
Checklist