Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LatencyMetrics parsing to take into account that getCount() retur… #561

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

burmanm
Copy link
Contributor

@burmanm burmanm commented Oct 28, 2024

…ns different reservoir values for 3.11/4.0 and 4.1/5.0. In latter, the reservoir stores in microseconds while in the first case, they are nanoseconds.

Fixes #560

…ns different reservoir values for 3.11/4.0 and 4.1/5.0. In latter, the reservoir stores in microseconds while in the first case, they are nanoseconds.
@burmanm burmanm force-pushed the fix_latency_timers branch from 20bd147 to 611b36d Compare October 28, 2024 14:38
Copy link
Contributor

@emerkle826 emerkle826 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine. As long as some of the MetricsIT tests pass, we can merge this

@burmanm burmanm merged commit 78e7f6d into master Oct 28, 2024
89 of 92 checks passed
@burmanm burmanm deleted the fix_latency_timers branch October 28, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LatencyMetrics processing is incorrect in certain Cassandra versions
2 participants