Add new parameter to /start, consistency. #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emerkle826
approved these changes
Nov 25, 2024
| .entity(Entity.text("Invalid replace IP passed: " + replaceIp)) | ||
| .build(); | ||
|
|
||
| cmdArgs.add(String.format("-Dcassandra.replace_address_first_boot=%s", replaceIp)); | ||
| if (!Strings.isNullOrEmpty(consistency)) { | ||
| if (app.dbExe.getAbsolutePath().endsWith("dse")) { | ||
| cmdArgs.add(String.format("-Ddse.consistent_replace=%s", consistency)); |
There was a problem hiding this comment.
Question:
In scenarios where we want to use this, is it possible we'd want to also configure
- REPAIR_PARALLELISM = "dse.consistent_replace.parallelism"
- REPAIR_RETRIES = "dse.consistent_replace.retries"
- SPLITS_PER_RANGE = "dse.consistent_replace.splits_per_range"
If so, then It would be best for this new parameter to be an Object that could marshal/unmarshal into JSON with the above attributes.
If the above aren't relevant, than I am good with this.
There was a problem hiding this comment.
Verified that these are not right now necessary. If user wants those, they can set them as JVM options anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports -Ddse.consistent_replace=X for DSE 6.8/6.9 only
Fixes #574
@emerkle826 I don't think we have the ability to test passed JVM parameters in the /start, at least I didn't see any existing tests for such.