Skip to content

Commit

Permalink
Add comment for adding validations for graceperiod
Browse files Browse the repository at this point in the history
Follow #821
  • Loading branch information
kachick committed Jun 2, 2024
1 parent ff2e09f commit 40238b2
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
2 changes: 2 additions & 0 deletions dist/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -31067,6 +31067,8 @@ var WaitFilterCondition = FilterCondition.extend(
// - Intentionally avoided to use enum for now. Only GitHub knows whole eventNames and the adding plans
// - Intentionally omitted in skip-list, let me know if you have the use-case
eventName: z2.string().min(1).optional(),
// Do not raise validation errors for the reasonability of value range.
// Even in equal_intervals mode, we can't enforce the possibility of the whole running time
startupGracePeriod: Durationable.default({ seconds: 10 })
}
).readonly();
Expand Down
4 changes: 4 additions & 0 deletions src/schema.ts
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,13 @@ const SkipFilterCondition = FilterCondition.readonly();
const WaitFilterCondition = FilterCondition.extend(
{
optional: z.boolean().optional().default(false).readonly(),

// - Intentionally avoided to use enum for now. Only GitHub knows whole eventNames and the adding plans
// - Intentionally omitted in skip-list, let me know if you have the use-case
eventName: z.string().min(1).optional(),

// Do not raise validation errors for the reasonability of value range.
// Even in equal_intervals mode, we can't enforce the possibility of the whole running time
startupGracePeriod: Durationable.default({ seconds: 10 }),
},
).readonly();
Expand Down

0 comments on commit 40238b2

Please sign in to comment.