Publish binary as development-latest #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcardon
approved these changes
Apr 23, 2024
|
Please squash all the wip commits together |
emilypi
reviewed
Apr 25, 2024
| @@ -42,5 +42,24 @@ jobs: | |||
| echo Building the project and its devShell | |||
| nix build .#check --log-lines 500 --show-trace | |||
|
|
|||
| echo Build the bundle | |||
| nix build .#pact-binary-bundle --log-lines 500 --show-trace --out-link pact-binary-bundle | |||
| tar -zcvf pact-binary-bundle.${{ matrix.os }}.tar.gz $(readlink pact-binary-bundle) | |||
There was a problem hiding this comment.
In retrospect, we should probably decide on what this should be named and come up with a convention for it. pact-binary-bundle.*.tar.gz isn't very friendly or informative
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds releasing binary artefacts once they pass CI as
development-latest. The general idea is to ship new versions of the LSP server via the VSCode plugin.PR checklist:
Additionally, please justify why you should or should not do the following: